Center the logo and login fields for setup page

[ChrisEdS]

Bugfix

This is a bugfix for my PR #33375 - During another test I noticed that this did not consider the setup (first setup of the server, setting an admin password).

Description

Force constant vertical height for login box over all devices (also in setup page)

Motivation and Context

I incorporate this function into almost every theme I create. The logo and credential fields are centered on each device. That's why I thought it would be great to integrate this improvement into our Core Theme.

How Has This Been Tested?

Manual tested on Chrome, Firefox, Edge browser with different resolutions and also mobile resolutions

Screenshots:

Before (Google Pixel2):

After (Google Pixel2):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[PVince81]

@ChrisEdS is this only relevant for the setup page ? I don't expect people to setup OC on their mobile phone that often.

this question is only to evaluate criticality for backporting

[ChrisEdS]

Indeed, the mobile phone will be not used so often for setup. Anyway, with smaller resolutions and more content on the setup page (as for example when setting up on a macOS) this behavior takes into account. The ownCloud logo is hidden, the p.info text is behind the login fields, ... I would feel more comfortable if the fix will be released.

[phil-davis]

@ownclouders rebase

[phil-davis]

CI was giving weird stuff like make: *** No rule to make target 'test-php-lint'. Stop.
It looks like this commit came off some old place in master when PHP lint was being run.
So I asked for a rebase.

[codecov]

Codecov Report

Merging #35047 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #35047      +/-   ##
============================================
- Coverage     65.37%   65.37%   -0.01%     
+ Complexity    18626    18622       -4     
============================================
  Files          1215     1215              
  Lines         70532    70510      -22     
  Branches       1295     1295              
============================================
- Hits          46112    46093      -19     
+ Misses        24046    24043       -3     
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.81% <ø> (-0.01%)	18622 <ø> (-4)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	80.46% <0%> (-0.64%)	0% <0%> (ø)
...atedfilesharing/lib/Command/PollIncomingShares.php	98.11% <0%> (-0.42%)	11% <0%> (-2%)
apps/files_sharing/js/PublicUploadView.js	67.39% <0%> (ø)	0% <0%> (ø)	⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php	46.85% <0%> (+0.96%)	19% <0%> (ø)	⬇️
apps/files_sharing/lib/External/Manager.php	77.84% <0%> (+1.3%)	30% <0%> (-2%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcab5a4...2041f4c. Read the comment docs.

[codecov]

Codecov Report

Merging #35047 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35047   +/-   ##
=========================================
  Coverage     65.37%   65.37%           
  Complexity    18626    18626           
=========================================
  Files          1215     1215           
  Lines         70532    70532           
  Branches       1295     1295           
=========================================
  Hits          46112    46112           
  Misses        24046    24046           
  Partials        374      374

Flag	Coverage Δ	Complexity Δ
#javascript	52.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.82% <ø> (ø)	18626 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcab5a4...2041f4c. Read the comment docs.

[PVince81]

@ChrisEdS it will be released with 10.3 then.

my question was mostly whether the bug affects other views like the login page (not setup) and maybe the full screen error page which might use the same layout template

[lordelix]

LGTM

[PVince81]

@ChrisEdS please merge and backport to stable10

[phil-davis]

Backport stable10 #35347