Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Contributor
|
@jvillafanez Can you cover the complex "edition" logic in a unit test? |
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Member
Author
|
Added tests matching the current logic |
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.07%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48962 +77
+ Misses 26323 26273 -50
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.5.0 #37654 +/- ##
====================================================
+ Coverage 64.66% 64.74% +0.08%
- Complexity 19343 19363 +20
====================================================
Files 1279 1281 +2
Lines 75600 75627 +27
Branches 1333 1333
====================================================
+ Hits 48885 48965 +80
+ Misses 26323 26270 -53
Partials 392 392
Continue to review full report at Codecov.
|
Member
Author
|
@micbar this is ready |
Contributor
micbar
approved these changes
Jul 6, 2020
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expired demo key will return community edition instead of enterprise
Related Issue
https://github.com/owncloud/enterprise/issues/4020
Motivation and Context
How Has This Been Tested?
Manually tested
Screenshots (if appropriate):
Types of changes
Checklist:
PR targets release-10.5.0 branch, It's expected to be merged into master along with the release changes