[full-ci] Implement persistent major version workflow (v2)

[mrow4a]

Description

Remark: For reviews, please keep in mind that this code is many years old with lots of legacies, I tried as much as I can not to refactor the code too much in order to avoid regressions and fit this change into OC10 release according to semver.

This PR introduces the following enhancements:

• Change no. 1: Restore operation logic changed. Now restore is creating new current version of the file from one of past noncurrent versions of the file. Current version also receives incremented mtime for the file, and author of the files is the user that restored the file. The old noncurrent version is no longer removed upon restore and current version no longer receives mtime of the version.
• Change no. 2: The current version of the file is now shown in the Versions Tab, highlighted with "gray" background

• Change no. 3: Versions now persist additional extended metadata on versioning tags, that allow easier identification of the versions. Each update increases minor version for the file

• Change no. 4: Current version of the file now can be published, which increases major version tag.
  

• Change no. 5: Each new edit of the file would create noncurrent versions. The ones tagged with major version due to publishing, will be persisted long term and it wont be subject to any retention policies
  

Related Issue

• Replaces [WIP] Implement persistent major version workflow #40319
• Implements https://github.com/owncloud/enterprise/issues/5286

How Has This Been Tested?

• manually in the developer instance
  • test with normal fs for file and folder
  • test with normal fs for shared file file and folder
  • test with trashbin for file and folder
  • test with objectstore (it should be properly disabled)
  • test with encryption (metafiles are plaintext, files/versions encrypted)
• unit/acceptance tests

Enable the feature and test generating new versions e.g. in shared folder on a document with TextEditor/OnlyOffice/Collabora

occ config:system:set file_storage.save_version_metadata --value true --type boolean

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• Base code changes
• Unit tests added
• Acceptance tests added
• Changelog item, see TEMPLATE
• Docs update document persistent major version feature docs-server#840

Example

• User test1 creates a file shared/nest/test1.txt, version tab shows current label on the latest version
• User test2 updates a file shared/nest/test1.txt two times, that creates two noncurrent versions
• User test2 publishes latest version shared/nest/test1.txt , and thus would prevent expiry in the future. File is now marked with persistent label
• Two more edits happen that increment the version tag

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

💥 Acceptance tests pipeline webUITags-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37534/143

[phil-davis]

https://drone.owncloud.com/owncloud/core/37534/9/7

There were 2 failures:

1) OCA\Files_Versions\Tests\VersioningTest::testExpire with data set "metaEnabled" (true)
Failed asserting that 3 matches expected 4.

/drone/src/apps/files_versions/tests/VersioningTest.php:354
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:97

2) OCA\Files_Versions\Tests\VersioningTest::testIsPublishedVersion with data set "metaEnabled" (true)
Failed asserting that false is true.

/drone/src/apps/files_versions/tests/VersioningTest.php:409
phpvfscomposer:///drone/src/lib/composer/phpunit/phpunit/phpunit:97

[phil-davis]

https://drone.owncloud.com/owncloud/core/37534/143/18

runsh: Total unexpected failed scenarios throughout the test run:
webUITags/editTags.feature:15
webUITags/editTags.feature:28

    And the user edits the tag with name "random" and sets its name to "random-big" using the webUI # WebUITagsContext::theUserEditsTheTagWithNameAndSetsItsNameToUsingTheWebui()
      Page\FilesPageElement\DetailsDialog::renameTagxpath: //input[@id='view12-rename-input'] could not find tag edit input (SensioLabs\Behat\PageObjectExtension\PageObject\Exception\ElementNotFoundException)

[phil-davis]

By default, CI gets killed as soon as one pipeline fails.
I suggest that you add [full-ci] to the PR title. Then all pipelines will run to completion and you can see all the things that are failing.

[mrow4a]

@phil-davis would you mind having a look into https://drone.owncloud.com/owncloud/core/37551/142/17 ? I quite cannot scratch my head what is the problem, my change has nothing to do with Tags Tab, it touches only Versions Tab. Also backend logic nowhere touches tags logic. Would be quite grateful 🙏🏻

can this be somehow related to 22985c0#diff-13542e9bb43fdf30fda1d9e9c04815936a6b19e6ab005b5c444c740f8e66646d (which is related to this exact feature) ?

[mrow4a]

@phil-davis started adjusting other acceptance tests due to the fact that PROPFIND now also returns current version and noncurrent version, plus restore logic changed.

And... found out that in one case there is a bug in my implementation (enable file versioning and check the history of changes from multiple users after renaming file by sharer) ... without these tests would never have thought of that corner case, good job!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
50 Code Smells

60.8% Coverage
3.7% Duplication

[jvillafanez]

Might need a squash, but code looks ok.

[mmattel]

@mrow4a pls add the change that you proposed in docs in config_sample_php_parameters here in core. I will then do a config-to-docs run post merging this PR which transports the changes to docs properly. Also see my comment in the docs PR you created (thanks for creating it!).

[jnweiger]

Confirmed fixed in 10.12.0-rc.3

• Persistent versions are retained with auto, other versions disapear as per policy.
• Persistent versions older than 2 days are retained with 'auto, 2', when occ versions:expire is run.
• Persistent versions are deleted by 'occ versions:cleanup' - which is expected and documented behaviour.
• Works fine also with encryption.