document persistent major version feature#840
Conversation
|
@mrow4a the change in |
jvillafanez
left a comment
There was a problem hiding this comment.
I'd change the image. The first time I saw it I thought the "publish version" below the check mark was a button, not a tooltip, so I was surprised when I didn't see the button.
I don't know how we can make it clear that it's a tooltip, so I think it's better to remove from the image. Just take the same screenshot without the tooltip showing, and maybe use a bit more realistic usernames
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
|
@mmattel what you mean is https://github.com/owncloud/core/blob/81e3c8b7e741d708f984b6c500eaadbe1dce348a/config/config.sample.php#L717-L723 ? It is already done? So it will be automatically done in |
|
just not in front of my nb, but any changes related to config sample must be made in core. if they already exist, fine. if in this pr, fine. if not, must be added. |
|
@jvillafanez adjusted to content review |
efb3480 to
6dfb9e9
Compare
0b09af0 to
d38d0fc
Compare
|
I have made a |
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/server/config_sample_php_parameters.adoc
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/server/config_sample_php_parameters.adoc
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/server/config_sample_php_parameters.adoc
Show resolved
Hide resolved
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
|
no changes in config sample pls. |
|
Note, beside the comment from phil-davis above, all is fixed and a language review made. The current build is visible on staging. @mrow4a pls take a look on that comment and respond or fix. Technically we could merge after that. |
|
as mentioned in #840 (comment) , newly added text is wrong |
modules/admin_manual/pages/configuration/files/file_versioning.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Phil Davis <phil@jankaritech.com>
9f2fdc8 to
c726b7c
Compare
fixed and rebased, ready to merge |
|
your call, I just made doc update suggestion 😉 |
References:
owncloud/core#40531 (Implement persistent major version workflow (v2))
owncloud/core#40636 ([docs-only] Fix headline in config.sample)
Document the persistent major version feature.
Needs a
config-to-docsrun (see commit config-to-docs run).No Backport