Allow stream wrappers not to provide the underlying stream#40659
Merged
jnweiger merged 1 commit intorelease-10.12.0from Feb 28, 2023
Merged
Allow stream wrappers not to provide the underlying stream#40659jnweiger merged 1 commit intorelease-10.12.0from
jnweiger merged 1 commit intorelease-10.12.0from
Conversation
This is mainly for streams that don't wrap another one, or use a stream not provided by the native fopen function such as smbclient_open
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Member
Author
|
This is kind of a bug fix for #40600 , which hasn't been released yet. I don't think we need a changelog entry |
|
Kudos, SonarCloud Quality Gate passed! |
DeepDiver1975
approved these changes
Feb 28, 2023
jnweiger
added a commit
that referenced
this pull request
Mar 13, 2023
* prepare 10.12 * update translations * Allow stream wrappers not to provide the underlying stream (#40659) This is mainly for streams that don't wrap another one, or use a stream not provided by the native fopen function such as smbclient_open * Fix issue if no version has been created yet (#40661) * fix link in changelog. * Revert .htaccess change * OCM via ScienceMesh Signed-off-by: Michiel de Jong <michiel@unhosted.org> * Get plugin from \OC::$server->query() * Improve changelog entry Signed-off-by: Michiel de Jong <michiel@unhosted.org> * improve changelog entry Signed-off-by: Michiel de Jong <michiel@unhosted.org> * Whitespace change to re-trigger CI Signed-off-by: Michiel de Jong <michiel@unhosted.org> * Upgrading phpseclib/phpseclib (3.0.18 => 3.0.19) * changelog for phpseclib 3.0.19 * Add test for the new feature * revert logic to expose free_space, but keep availableStorage config * Make sender display name in mail notifications configurable (#40671) * [tx] updated from transifex * [tx] updated from transifex * make getFrom configurable * fix style * Adjust unit tests for MailNotificationsTest * add changelog * Document remove_sender_display_name system setting * Add unit test cases for when remove_sender_display_name is set to true --------- Co-authored-by: ownClouders <devops@owncloud.com> Co-authored-by: Phil Davis <phil@jankaritech.com> * removing double to * prepare 10.12.0 RC3 * Bump final 10.12.0 version in version.php --------- Signed-off-by: Michiel de Jong <michiel@unhosted.org> Co-authored-by: Juergen Weigert <jnweiger@gmail.com> Co-authored-by: Juan Pablo Villafañez <jvillafanez@solidgeargroup.com> Co-authored-by: Michiel de Jong <michiel@unhosted.org> Co-authored-by: Piotr Mrówczyński <piotr@owncloud.com> Co-authored-by: Pasquale Tripodi <ptripodi@owncloud.com> Co-authored-by: ownClouders <devops@owncloud.com> Co-authored-by: EParzefall <edith_parzefall@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








This is mainly for streams that don't wrap another one, or use a stream not provided by the native fopen function such as smbclient_open
NOTE: This PR targets the release branch.
Description
Provide a way not to provide the source of the stream, otherwise we'd get an annoying log complaining about the missing
getSourcemethod in the stream, or we could get real errors if the last stream isn't native.Related Issue
No opened issue yet.
Motivation and Context
Prevent annoying logs. The flow still works without problems, but the log will keep appearing
How Has This Been Tested?
Manually tested
The warning log appears.
Note that this PR won't solve the issue by itself. It requires changes in the WND app.
Changes in the app (not core) are expected to be backwards-compatible.
Screenshots (if appropriate):
Types of changes
Checklist:
Expected logs with this PR:
As told in the log, the app will provide such method (still to be done)