Skip to content

Fix issue if no version has been created yet#40661

Merged
jnweiger merged 1 commit intorelease-10.12.0from
fix_version_log_delete
Mar 2, 2023
Merged

Fix issue if no version has been created yet#40661
jnweiger merged 1 commit intorelease-10.12.0from
fix_version_log_delete

Conversation

@jvillafanez
Copy link
Copy Markdown
Member

@jvillafanez jvillafanez commented Feb 28, 2023 •
edited
Loading

Description

NOTE: This PR targets the release branch.
Removing files triggers an error if no version has been created yet

{"reqId":"dj3MshxIYLvEAflrxzft","level":3,"time":"2023-02-28T12:42:28+00:00","remoteAddr":"10.0.2.27","user":"mountainUser1@mountain.tree.prv","app":"PHP","method":"DELETE","url":"\/remote.php\/dav\/files\/mountainUser1%40mountain.tree.prv\/5cwx14ct1tx81.jpg","message":"opendir(\/mnt\/data\/files\/mountainUser1@mountain.tree.prv\/files_versions): failed to open dir: No such file or directory at \/var\/www\/owncloud\/lib\/private\/Files\/Storage\/Local.php#119"}

This is likely to be caused by #40499 . The behavior of the feature should be safe without this patch (there are checks in place in case the directory can't be opened), but the log can be annoying.

Related Issue

No issue opened yet. Seen in 10.12 rc

Motivation and Context

The error happens every time a file is deleted.

How Has This Been Tested?

Manually tested

  1. Fresh OC installation
  2. Upload a file
  3. Delete the same file

The error appears in the log.
Also tested with an external directory.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Feb 28, 2023
@update-docs
Copy link
Copy Markdown

update-docs bot commented Feb 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez
Copy link
Copy Markdown
Member Author

jvillafanez commented Feb 28, 2023

This is a bug fix for #40499, so no changelog entry needed.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger merged commit c0ef0f8 into release-10.12.0 Mar 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_version_log_delete branch March 2, 2023 10:10
@jnweiger jnweiger mentioned this pull request Mar 8, 2023
Merged
jnweiger added a commit that referenced this pull request Mar 13, 2023
@phil-davis @jnweiger
@jvillafanez @michielbdejong @mrow4a @ownclouders @EParzefall
Merge back 10.12.0 (#40682)
0d817c8 
* prepare 10.12

* update translations

* Allow stream wrappers not to provide the underlying stream (#40659)

This is mainly for streams that don't wrap another one, or use
a stream not provided by the native fopen function such as
smbclient_open

* Fix issue if no version has been created yet (#40661)

* fix link in changelog.

* Revert .htaccess change

* OCM via ScienceMesh

Signed-off-by: Michiel de Jong <michiel@unhosted.org>

* Get plugin from \OC::$server->query()

* Improve changelog entry

Signed-off-by: Michiel de Jong <michiel@unhosted.org>

* improve changelog entry

Signed-off-by: Michiel de Jong <michiel@unhosted.org>

* Whitespace change to re-trigger CI

Signed-off-by: Michiel de Jong <michiel@unhosted.org>

* Upgrading phpseclib/phpseclib (3.0.18 => 3.0.19)

* changelog for phpseclib 3.0.19

* Add test for the new feature

* revert logic to expose free_space, but keep availableStorage config

* Make sender display name in mail notifications configurable (#40671)

* [tx] updated from transifex

* [tx] updated from transifex

* make getFrom configurable

* fix style

* Adjust unit tests for MailNotificationsTest

* add changelog

* Document remove_sender_display_name system setting

* Add unit test cases for when remove_sender_display_name is set to true

---------

Co-authored-by: ownClouders <devops@owncloud.com>
Co-authored-by: Phil Davis <phil@jankaritech.com>

* removing double to

* prepare 10.12.0 RC3

* Bump final 10.12.0 version in version.php

---------

Signed-off-by: Michiel de Jong <michiel@unhosted.org>
Co-authored-by: Juergen Weigert <jnweiger@gmail.com>
Co-authored-by: Juan Pablo Villafañez <jvillafanez@solidgeargroup.com>
Co-authored-by: Michiel de Jong <michiel@unhosted.org>
Co-authored-by: Piotr Mrówczyński <piotr@owncloud.com>
Co-authored-by: Pasquale Tripodi <ptripodi@owncloud.com>
Co-authored-by: ownClouders <devops@owncloud.com>
Co-authored-by: EParzefall <edith_parzefall@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

+1 more reviewer

@IljaN IljaN IljaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jvillafanez jvillafanez

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jvillafanez @IljaN @phil-davis @jnweiger