change FD_ISSET to use *const raw pointer.#308
change FD_ISSET to use *const raw pointer.#308cpjreynolds wants to merge 1 commit intorust-lang:masterfrom cpjreynolds:master
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This unfortunately has the potential to be a breaking change, and according to the spec it looks like this "function" signature uses |
|
Interesting, I hadn't considered the spec when making the changes. Unfortunate that the spec doesn't specify a |
Looks like intrinsics that weren't listing a target feature were accidentally omitted from the verification logic, so this commit fixes that! Along the way I've ended up filing rust-lang#307 and rust-lang#308 for detected inconsistencies.
Some more info should be in rust-lang#308, and otherwise ... Closes rust-lang#308
3 participants
Considering that
FD_ISSETdoes not modifyfd_set, it only needs a*constpointer to it.