Add example to IsTerminal::is_terminal#124992
Merged
bors merged 1 commit intorust-lang:masterfrom May 19, 2024
Merged
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ChrisDenton (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
foresterre
force-pushed
the
example/is-terminal
branch
from
baf0506 to
851ffd9
Compare
This comment has been minimized.
This comment has been minimized.
foresterre
force-pushed
the
example/is-terminal
branch
from
851ffd9 to
b729070
Compare
This comment has been minimized.
This comment has been minimized.
foresterre
force-pushed
the
example/is-terminal
branch
2 times, most recently
from
4506240 to
1e56160
Compare
This comment has been minimized.
This comment has been minimized.
foresterre
force-pushed
the
example/is-terminal
branch
from
1e56160 to
20e1773
Compare
This comment has been minimized.
This comment has been minimized.
foresterre
force-pushed
the
example/is-terminal
branch
2 times, most recently
from
ed46c9b to
38ba445
Compare
ChrisDenton
reviewed
May 19, 2024
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
This looks good. I'm fine with it as-is but there are a couple of things which I think might make it better.
| /// | ||
| /// # Examples | ||
| /// | ||
| /// An example of a type for which `IsTerminal` is implemented is [`Stdin`]: |
Member
There was a problem hiding this comment.
It'd be great, though not essential, to have an example that includes both Stdin and Stdout.
foresterre
force-pushed
the
example/is-terminal
branch
from
38ba445 to
0b6baf6
Compare
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124948 (chore: Remove repeated words (extension of rust-lang#124924)) - rust-lang#124992 (Add example to IsTerminal::is_terminal) - rust-lang#125279 (make `Debug` impl for `Term` simpler) - rust-lang#125286 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 19, 2024
Rollup merge of rust-lang#124992 - foresterre:example/is-terminal, r=ChrisDenton Add example to IsTerminal::is_terminal
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124948 (chore: Remove repeated words (extension of rust-lang#124924)) - rust-lang#124992 (Add example to IsTerminal::is_terminal) - rust-lang#125279 (make `Debug` impl for `Term` simpler) - rust-lang#125286 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.