Skip to content

make Debug impl for Term simpler#125279

Merged
bors merged 1 commit intorust-lang:masterfrom
WaffleLapkin:unpacktermindebug
May 19, 2024
Merged

make Debug impl for Term simpler#125279
bors merged 1 commit intorust-lang:masterfrom
WaffleLapkin:unpacktermindebug

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin commented May 19, 2024

meow

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 19, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 19, 2024
@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

📌 Commit 9186197 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented May 19, 2024

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

📌 Commit 9186197 has been approved by BoxyUwU

It is now in the queue for this repository.

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

📌 Commit 9186197 has been approved by Nilstrieb

It is now in the queue for this repository.

@aDotInTheVoid
Copy link
Copy Markdown
Member

aDotInTheVoid commented May 19, 2024

@bors rollup=always

@BoxyUwU BoxyUwU assigned BoxyUwU and Noratrieb and unassigned TaKO8Ki May 19, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid reviewed May 19, 2024
View reviewed changes
compiler/rustc_middle/src/ty/mod.rs Outdated
};
f.write_str(&data)
match self.unpack() {
TermKind::Ty(ty) => write!("Term::Ty({ty:?})"),
Copy link
Copy Markdown
Member

@aDotInTheVoid aDotInTheVoid May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TermKind::Ty(ty) => write!("Term::Ty({ty:?})"),
TermKind::Ty(ty) => write!(f, "Term::Ty({ty:?})"),

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

fuck

@aDotInTheVoid
Copy link
Copy Markdown
Member

aDotInTheVoid commented May 19, 2024

r=me when CI's green

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024 •
edited
Loading

CI is green
@bors=aDotInTheVoid,Nilstrieb,BoxyUwU
image

@BoxyUwU BoxyUwU removed their assignment May 19, 2024
@jyn514
Copy link
Copy Markdown
Member

jyn514 commented May 19, 2024

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

@jyn514: 🔑 Insufficient privileges: Not in reviewers

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

☝️

@aDotInTheVoid
Copy link
Copy Markdown
Member

aDotInTheVoid commented May 19, 2024

i think bors knows something jyn

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented May 19, 2024 •
edited
Loading

>:(

@aDotInTheVoid
Copy link
Copy Markdown
Member

aDotInTheVoid commented May 19, 2024

image

@BoxyUwU
Copy link
Copy Markdown
Member

BoxyUwU commented May 19, 2024 •
edited
Loading

Should we file a security incident about some random person trying to r+ rust PRs? Could be a potential attacker. (they are a self proclaimed "hacker")

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented May 19, 2024

clearly the solution is to make this pr more gay
image

@aDotInTheVoid
Copy link
Copy Markdown
Member

aDotInTheVoid commented May 19, 2024

Should we file a security incident about some random person trying to r+ rust PRs? Could be a potential attacker. (they are a self proclaimed "hacker")

with the state of bors these days I wouldn't be surprised if this worked

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented May 19, 2024

@bors try r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

@jyn514: 🔑 Insufficient privileges: not in try users

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

@jyn514: 🔑 Insufficient privileges: Not in reviewers

@jyn514
Copy link
Copy Markdown
Member

jyn514 commented May 19, 2024

(they are a self proclaimed "hacker")

ok fixed
image

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

@bors r=aDotInTheVoid,Nilstrieb,BoxyUwU

@bors
Copy link
Copy Markdown
Collaborator

bors commented May 19, 2024

📌 Commit 006866f has been approved by aDotInTheVoid,Nilstrieb,BoxyUwU

It is now in the queue for this repository.

@Noratrieb
Copy link
Copy Markdown
Member

Noratrieb commented May 19, 2024

i am so sorry i messed up :((((

@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented May 19, 2024 •
edited
Loading

It's okay, we all mess up sometimes 💜

@matthiaskrgr matthiaskrgr mentioned this pull request May 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2024
@bors
Auto merge of rust-lang#125294 - matthiaskrgr:rollup-w42c829, r=matth…
d84b903 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124948 (chore: Remove repeated words (extension of rust-lang#124924))
 - rust-lang#124992 (Add example to IsTerminal::is_terminal)
 - rust-lang#125279 (make `Debug` impl for `Term` simpler)
 - rust-lang#125286 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 131d48f into rust-lang:master May 19, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2024
@rust-timer
Unrolled build for rust-lang#125279
9291c42 
Rollup merge of rust-lang#125279 - WaffleLapkin:unpacktermindebug, r=aDotInTheVoid,Nilstrieb,BoxyUwU

make `Debug` impl for `Term` simpler

meow
@WaffleLapkin WaffleLapkin deleted the unpacktermindebug branch May 20, 2024 01:48
bors added a commit to rust-lang-ci/rust that referenced this pull request May 30, 2024
@bors
Auto merge of rust-lang#125294 - matthiaskrgr:rollup-w42c829, r=matth…
298f38c 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124948 (chore: Remove repeated words (extension of rust-lang#124924))
 - rust-lang#124992 (Add example to IsTerminal::is_terminal)
 - rust-lang#125279 (make `Debug` impl for `Term` simpler)
 - rust-lang#125286 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aDotInTheVoid aDotInTheVoid aDotInTheVoid left review comments

Assignees

@BoxyUwU BoxyUwU

@aDotInTheVoid aDotInTheVoid

@Noratrieb Noratrieb

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.80.0

Development

Successfully merging this pull request may close these issues.

9 participants

@WaffleLapkin @rustbot @Noratrieb @bors @BoxyUwU @aDotInTheVoid @rust-log-analyzer @jyn514 @TaKO8Ki