Rename needs-matching-clang to needs-force-clang-based-tests#126257
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 11, 2024
Merged
Rename needs-matching-clang to needs-force-clang-based-tests#126257bors merged 1 commit intorust-lang:masterfrom
needs-matching-clang to needs-force-clang-based-tests#126257bors merged 1 commit intorust-lang:masterfrom
Conversation
This header is much more restrictive than its old name would suggest. As a result, most of the tests that use it don't actually run in any CI jobs.
Collaborator
rustbot
added
A-run-make
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies cc @jieyouxu |
jieyouxu
approved these changes
Jun 11, 2024
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#125913 (Spruce up the diagnostics of some early lints) - rust-lang#126234 (Delegation: fix ICE on late diagnostics) - rust-lang#126253 (Simplify assert matchers in `run-make-support`) - rust-lang#126257 (Rename `needs-matching-clang` to `needs-force-clang-based-tests`) - rust-lang#126259 (reachable computation: clarify comments around consts) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup merge of rust-lang#126257 - Zalathar:needs-matching-clang, r=jieyouxu Rename `needs-matching-clang` to `needs-force-clang-based-tests` This header is much more restrictive than its old name would suggest. As a result, most of the tests that use it don't actually run in any CI jobs. Mitigation for rust-lang#126180, though at some point we still need to go back fix the affected tests to actually run.
This was referenced Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This header is much more restrictive than its old name would suggest. As a result, most of the tests that use it don't actually run in any CI jobs.
Mitigation for #126180, though at some point we still need to go back fix the affected tests to actually run.