➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2018-03-08 15:15 by siddhesh, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10746 | merged | serhiy.storchaka, 2018-11-27 16:44 | |
| PR 10747 | merged | miss-islington, 2018-11-27 17:34 | |
| PR 10749 | merged | serhiy.storchaka, 2018-11-27 17:48 | |
| Messages (7) | |||
|---|---|---|---|
| msg313443 - (view) | Author: Siddhesh Poyarekar (siddhesh) * | Date: 2018-03-08 15:15 | |
gcc 8 has added a new warning heuristic to detect invalid function casts and a stock python build seems to hit that warning quite often. bug 33012 fixes the most trivial case of METH_NOARGS, this bug is to track a similarly trivial but widely applicable fix, which is to cast getter and setter functions. Patches coming up over the weekend. |
|||
| msg330507 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-11-27 11:30 | |
Can you provide your patches Siddhesh? |
|||
| msg330513 - (view) | Author: Siddhesh Poyarekar (siddhesh) * | Date: 2018-11-27 11:54 | |
Sorry I haven't had time to look into this since and it doesn't look like I'll be able to get to it in the next couple of weeks. I had a couple of patches in the github fork but they're pretty outdated and probably not even correct. If nobody gets to it by Christmas holidays, I'll give it a shot. |
|||
| msg330541 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-27 17:34 | |
New changeset d4f9cf5545d6d8844e0726552ef2e366f5cc3abd by Serhiy Storchaka in branch 'master': bpo-33029: Fix signatures of getter and setter functions. (GH-10746) https://github.com/python/cpython/commit/d4f9cf5545d6d8844e0726552ef2e366f5cc3abd |
|||
| msg330543 - (view) | Author: miss-islington (miss-islington) | Date: 2018-11-27 17:58 | |
New changeset 5ceb7018dc63fab96f81d05e62bbe704e9f10cb9 by Miss Islington (bot) in branch '3.7': bpo-33029: Fix signatures of getter and setter functions. (GH-10746) https://github.com/python/cpython/commit/5ceb7018dc63fab96f81d05e62bbe704e9f10cb9 |
|||
| msg330546 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-27 18:38 | |
New changeset 29d2f3c47280f05795c9d4d70f4018cb1488f0ab by Serhiy Storchaka in branch '3.6': [3.6] bpo-33029: Fix signatures of getter and setter functions. (GH-10746) (GH-10749) https://github.com/python/cpython/commit/29d2f3c47280f05795c9d4d70f4018cb1488f0ab |
|||
| msg330550 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-27 18:55 | |
I have done this. Thank you for reporting about this issue. I don't have enough motivation for making a backport for 2.7. If someone want to do this, a PR is welcome. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:58 | admin | set | github: 77210 |
| 2018-11-27 18:55:03 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg330550 stage: patch review -> resolved |
| 2018-11-27 18:38:39 | serhiy.storchaka | set | messages: + msg330546 |
| 2018-11-27 17:58:10 | miss-islington | set | nosy:
+ miss-islington messages: + msg330543 |
| 2018-11-27 17:48:30 | serhiy.storchaka | set | pull_requests: + pull_request9997 |
| 2018-11-27 17:34:51 | miss-islington | set | pull_requests: + pull_request9995 |
| 2018-11-27 17:34:38 | serhiy.storchaka | set | messages: + msg330541 |
| 2018-11-27 16:44:00 | serhiy.storchaka | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request9994 |
| 2018-11-27 16:33:03 | serhiy.storchaka | set | assignee: serhiy.storchaka versions: + Python 3.6, Python 3.7 |
| 2018-11-27 11:54:28 | siddhesh | set | messages: + msg330513 |
| 2018-11-27 11:30:20 | serhiy.storchaka | set | messages: + msg330507 |
| 2018-03-08 19:12:29 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka stage: needs patch versions: + Python 3.8 |
| 2018-03-08 15:15:02 | siddhesh | create | |
