bpo-33029: Fix more invalid function cast warnings with gcc 8. #10746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix signatures of getter and setter functions. Fix return type for few other functions.
serhiy-storchaka
added
type-bug
serhiy-storchaka
requested review from
1st1,
asvetlov and
rhettinger
as code owners
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10747 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2018
…0746) Fix also return type for few other functions (clear, releasebuffer). (cherry picked from commit d4f9cf5) Co-authored-by: Serhiy Storchaka <[email protected]>
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-10749 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2018
Fix also return type for few other functions (clear, releasebuffer). (cherry picked from commit d4f9cf5) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Nov 27, 2018
…onGH-10746) Fix also return type for few other functions (clear, releasebuffer). (cherry picked from commit d4f9cf5)
serhiy-storchaka
added a commit
that referenced
this pull request
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix signatures of getter and setter functions. Fix return type
for few other functions.
https://bugs.python.org/issue33029