Invalid function cast warnings with gcc 8 for getter and setter functions

[siddhesh]

BPO	33029
Nosy	@serhiy-storchaka, @siddhesh, @miss-islington
PRs	bpo-33029: Fix more invalid function cast warnings with gcc 8. #10746 [3.7] bpo-33029: Fix signatures of getter and setter functions. (GH-10746) #10747 [3.6] bpo-33029: Fix signatures of getter and setter functions. (GH-10746) #10749

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2018-11-27.18:55:03.764>
created_at = <Date 2018-03-08.15:15:02.847>
labels = ['3.8', 'build', '3.7']
title = 'Invalid function cast warnings with gcc 8 for getter and setter functions'
updated_at = <Date 2018-11-27.18:55:03.763>
user = 'https://github.com/siddhesh'

bugs.python.org fields:

activity = <Date 2018-11-27.18:55:03.763>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2018-11-27.18:55:03.764>
closer = 'serhiy.storchaka'
components = ['Build']
creation = <Date 2018-03-08.15:15:02.847>
creator = 'siddhesh'
dependencies = []
files = []
hgrepos = []
issue_num = 33029
keywords = ['patch']
message_count = 7.0
messages = ['313443', '330507', '330513', '330541', '330543', '330546', '330550']
nosy_count = 3.0
nosy_names = ['serhiy.storchaka', 'siddhesh', 'miss-islington']
pr_nums = ['10746', '10747', '10749']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue33029'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[siddhesh]

gcc 8 has added a new warning heuristic to detect invalid function casts and a stock python build seems to hit that warning quite often. bug 33012 fixes the most trivial case of METH_NOARGS, this bug is to track a similarly trivial but widely applicable fix, which is to cast getter and setter functions.

Patches coming up over the weekend.

[serhiy-storchaka]

Can you provide your patches Siddhesh?

[siddhesh]

Sorry I haven't had time to look into this since and it doesn't look like I'll be able to get to it in the next couple of weeks. I had a couple of patches in the github fork but they're pretty outdated and probably not even correct.

If nobody gets to it by Christmas holidays, I'll give it a shot.

[serhiy-storchaka]

New changeset d4f9cf5 by Serhiy Storchaka in branch 'master':
bpo-33029: Fix signatures of getter and setter functions. (GH-10746)
d4f9cf5

[miss-islington]

New changeset 5ceb701 by Miss Islington (bot) in branch '3.7':
bpo-33029: Fix signatures of getter and setter functions. (GH-10746)
5ceb701

[serhiy-storchaka]

New changeset 29d2f3c by Serhiy Storchaka in branch '3.6':
[3.6] bpo-33029: Fix signatures of getter and setter functions. (GH-10746) (GH-10749)
29d2f3c

[serhiy-storchaka]

I have done this. Thank you for reporting about this issue.

I don't have enough motivation for making a backport for 2.7. If someone want to do this, a PR is welcome.