[🐛 Bug]: org.openqa.selenium.InvalidSelectorException is not thrown by fluent wait even when it's not ignored

[MohabMohie]

What happened?

https://seleniumhq.slack.com/archives/C0ABCS03F/p1677391208456589

I'm using an invalid element locator (for testing purposes) and I'm trying to identify that element within a fluent wait
The fluent wait is ignoring some exceptions (not including org.openqa.selenium.InvalidSelectorException)
Expected Behavior: the invalid selector exception should be thrown immediately
Actual Behavior: it gets caught and rethrown recursively until a timeout occurs, and then a timeout is thrown with the cause InvalidSelectorException
Here's a gist with the fluentWait block, the expected exceptions block, and a screenshot from the throwable object.
https://gist.github.com/MohabMohie/6c4d16bfca0ad7b15c3e274b631ecdf9
Is this a bug or am I doing something wrong?

How can we reproduce the issue?

https://gist.github.com/MohabMohie/6c4d16bfca0ad7b15c3e274b631ecdf9

Relevant log output

N/A

Operating System

Windows 11

Selenium version

Java 4.8.1

What are the browser(s) and version(s) where you see this issue?

N/A

What are the browser driver(s) and version(s) where you see this issue?

N/A

Are you using Selenium Grid?

N/A

[github-actions]

@MohabMohie, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[github-actions]

Hi, @MohabMohie.
Please follow the issue template, we need more information to reproduce the issue.

Either a complete code snippet and URL/HTML (if more than one file is needed, provide a GitHub repo and instructions to run the code), the specific versions used, or a more detailed description to help us understand the issue.

Note: If you cannot share your code and URL/HTML, any complete code snippet and URL/HTML that reproduces the issue is good enough.

Reply to this issue when all information is provided, thank you.

[titusfortner]

The issue is that InvalidSelectorException subclasses NoSuchElementException.
https://github.com/SeleniumHQ/selenium/blob/selenium-4.8.1/java/src/org/openqa/selenium/InvalidSelectorException.java#L28

This results in incorrect waiting behavior because a bad selector can never be fixed. I believe we had a conversation about this when I changed it in Python. There might be another open issue somewhere about this.

[MohabMohie]

@titusfortner I'd love to help fix the issue if you can give me some guidance or a reference in the python code to look at an mimic :)

[MohabMohie]

found the other issue and the agreement
#10833

[titusfortner]

@diemol did we discuss this in a tlc meeting? I can't remember what we discussed or what we decided previously.

[diemol]

https://www.selenium.dev/meetings/2022/tlc-08-17/#proposals

[MohabMohie]

I really really want to do this change guys :D looks easy enough as a first contribution :D
I've been wanting to contribute for a while now...

[diemol]

Yes, please help us with a pull request. And even a blog post describing the change would be awesome!

[MohabMohie]

Okay, I made the fork, and will make the change and open a PR
I'll explore to see how to make a blog post... I noticed that you guys recently migrated to docusaurus 2, so that should be something I can manage 👍