Skip to content

extending WebDriverException #11727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diemol merged 4 commits into from
Mar 3, 2023
Merged

extending WebDriverException #11727

diemol merged 4 commits into from
Mar 3, 2023

Conversation

@MohabMohie
Copy link
Contributor

@MohabMohie MohabMohie commented Mar 2, 2023 •
edited
Loading

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

This was referenced Mar 2, 2023
Merged
Closed
diemol
diemol requested changes Mar 2, 2023
View reviewed changes
@MohabMohie MohabMohie requested a review from diemol March 3, 2023 06:51
diemol
diemol approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MohabMohie!

@diemol diemol force-pushed the InvalidSelectorException_fixes_#11712 branch from 12c4648 to 3d182e5 Compare March 3, 2023 11:43
@diemol diemol merged commit 3179985 into SeleniumHQ:trunk Mar 3, 2023
@joerg1985 joerg1985 mentioned this pull request Mar 30, 2023
Closed
diemol added a commit to SeleniumHQ/seleniumhq.github.io that referenced this pull request Apr 21, 2023
@MohabMohie @diemol
Create InvalidSelectorException_is_changing.md (#1325)
e61949c 
documenting the change made by this PR SeleniumHQ/selenium#11727 and its potential backwards compatibility impact

Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: org.openqa.selenium.InvalidSelectorException is not thrown by fluent wait even when it's not ignored

2 participants

@MohabMohie @diemol