Skip to content

Conversation

@MohabMohie
Copy link
Contributor

@MohabMohie MohabMohie commented Mar 2, 2023

documenting the change made by this PR SeleniumHQ/selenium#11727 and its potential backwards compatibility impact

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

documenting the change made by this PR SeleniumHQ/selenium#11727 and its potential backwards compatibility impact
@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit bf777aa
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6442c4401d649600084a7a87
😎 Deploy Preview https://deploy-preview-1325--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MohabMohie
Copy link
Contributor Author

@diemol for your review please, the blog post for the change to invalid locator exception.

@diemol
Copy link
Member

diemol commented Apr 21, 2023

Now that we released 4.9.0, let's merge this.

@MohabMohie
Copy link
Contributor Author

@diemol I don't have permission to squash/merge the PR. But I updated the branch.

@diemol
Copy link
Member

diemol commented Apr 21, 2023

No worries, I will merge and do some changes before publishing. Thank you.

@diemol diemol merged commit e61949c into SeleniumHQ:trunk Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants