Use .NET 4.0 - fixes #160 #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Still working on it. Please do not merge. |
Member
Author
|
It now creates nuget package for .NET 4.0 and 4.5. Ready to merge |
Contributor
There was a problem hiding this comment.
Could you make the default when developing be v4.5 please? Thanks
Member
Author
|
It's also running nunit on both dlls, but sourcelink is only happening for 4.5 |
Member
Author
|
seems it's still compiled in .NET 4.5. I'll investigate. |
Member
Author
|
Here is my second trial: #167 |
ctaggart
pushed a commit
to ctaggart/FSharp.Compiler.Service
that referenced
this pull request
Jul 2, 2014
dsyme
added a commit
to dsyme/FSharp.Compiler.Service
that referenced
this pull request
Mar 23, 2015
fixes fsharp#163 closes fsharp#172 commit 1d8b42efda514357bcb14bd1838a4e9c6dc3cdab Author: Don Syme <[email protected]> Date: Thu Jan 29 10:15:54 2015 +0000 NOP commit to run appveyor commit 290c154a5c68c517a395db0c57553a45b5dea85e Author: Don Syme <[email protected]> Date: Thu Jan 29 01:13:14 2015 +0000 minor update to fix commit 210201dcce89c9d1875056686c57093b5df04a32 Author: Don Syme <[email protected]> Date: Thu Jan 29 01:06:30 2015 +0000 FIx fsharp#163 - Array2d.* don't work on non-zero-based arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what happens.