Skip to content

The FSharp.Core should be retrieved from the hosting environment #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fsgit merged 3 commits into from
Jul 1, 2014
Merged

The FSharp.Core should be retrieved from the hosting environment #172

fsgit merged 3 commits into from
Jul 1, 2014

Conversation

@forki
Copy link
Member

@forki forki commented Jul 1, 2014

@forki forki mentioned this pull request Jul 1, 2014
Closed
@7sharp9
Copy link
Member

7sharp9 commented Jul 1, 2014

I have no idea what you are doing either?

"The FSharp.Core should be retrieved from the hosting environment" The hosting environment being the IDE?

@rneatherway
Copy link
Member

rneatherway commented Jul 1, 2014

I think he means whatever FSharp.Core is being used by the running application that is in turn making a call to FCS. Rather than FCS choosing an FSharp.Core @forki would like it to use the one the running application is using.

@7sharp9
Copy link
Member

7sharp9 commented Jul 1, 2014

We need to be a little careful with changes here as they could break tooltips and autocompletion for downstream users.

@7sharp9
Copy link
Member

7sharp9 commented Jul 1, 2014

Should the logic also be applied in some way to mono resolution too?

@forki
Copy link
Member Author

forki commented Jul 1, 2014

@7sharp9 the issue is that FSharp.Core 4.3.0.0 needed to be installed in the GAC. Now we try to use the FSharp.Core that hopefully lies around.

@forki
Copy link
Member Author

forki commented Jul 1, 2014

@7sharp9 The mono path doesn't bind to FSharp.Core 4.3.0.0 or any version so I think that's fine.

fsgit added a commit that referenced this pull request Jul 1, 2014
@fsgit
Merge pull request #172 from forki/FSCore
26f5701 
The FSharp.Core should be retrieved from the hosting environment
@fsgit fsgit merged commit 26f5701 into fsharp:master Jul 1, 2014
@fsgit
Copy link
Contributor

fsgit commented Jul 1, 2014

Pushed FCS 0.0.58.

ctaggart pushed a commit to ctaggart/FSharp.Compiler.Service that referenced this pull request Jul 2, 2014
@dsyme
Fix fsharp#172 - On Mono #I paths don't work for assembly references
38e8642
@forki forki deleted the FSCore branch July 2, 2014 07:06
@forki forki mentioned this pull request Aug 8, 2014
Closed
dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Mar 23, 2015
@dsyme @latkin
Fix fsharp#163 - Array2d.* don't work on non-zero-based arrays
57f4f68 
fixes fsharp#163
closes fsharp#172

commit 1d8b42efda514357bcb14bd1838a4e9c6dc3cdab
Author: Don Syme <[email protected]>
Date:   Thu Jan 29 10:15:54 2015 +0000

    NOP commit to run appveyor

commit 290c154a5c68c517a395db0c57553a45b5dea85e
Author: Don Syme <[email protected]>
Date:   Thu Jan 29 01:13:14 2015 +0000

    minor update to fix

commit 210201dcce89c9d1875056686c57093b5df04a32
Author: Don Syme <[email protected]>
Date:   Thu Jan 29 01:06:30 2015 +0000

    FIx fsharp#163 - Array2d.* don't work on non-zero-based arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

By default compilations using FCS reference FSharp.Core 4.3.0.0

4 participants

@forki @7sharp9 @rneatherway @fsgit