Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Aug 21, 2020

Increase clickable area for links in the file table and remove one useless wrapping <span>.

Before (Clickable area is highlighted in red):

image

After:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 21, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Aug 22, 2020
@lafriks lafriks added this to the 1.13.0 milestone Aug 22, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 23, 2020
@silverwind
Copy link
Member Author

Comment added and squashed.

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit dd8ec12 into go-gitea:master Aug 23, 2020
@silverwind silverwind deleted the file-click-area branch August 23, 2020 19:41
silverwind added a commit to silverwind/gitea that referenced this pull request Aug 25, 2020
- Fix overflow regression from go-gitea#12553.
- Fix submodule columns stretching the table
- Refactor template to share more HTML nodes
- Introduce CSS helper classes
techknowlogick added a commit that referenced this pull request Aug 26, 2020
- Fix overflow regression from #12553.
- Fix submodule columns stretching the table
- Refactor template to share more HTML nodes
- Introduce CSS helper classes

Co-authored-by: zeripath <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants