Skip to content

Fix file table overflows #12603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 3 commits into from
Aug 26, 2020
Merged

Fix file table overflows #12603

techknowlogick merged 3 commits into from
Aug 26, 2020

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Aug 25, 2020 •
edited
Loading

Clickable areas:

image

@silverwind silverwind mentioned this pull request Aug 25, 2020
Closed
3 tasks
@silverwind silverwind force-pushed the fix-links branch 2 times, most recently from 6490987 to 481810e Compare August 25, 2020 17:53
@silverwind
Copy link
Member Author

silverwind commented Aug 25, 2020

Margin around @ restored. Also added a helpers.less file which is meant to contain a few simple single-class CSS helpers that will allow use to cut down on having to add classes and big css selectors everywhere for simple style adjustments.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 25, 2020
@silverwind silverwind force-pushed the fix-links branch 2 times, most recently from 52f2238 to fdb7d46 Compare August 25, 2020 20:50
@silverwind
Fix file table overflows
c88f3d8 
- Fix overflow regression from go-gitea#12553.
- Fix submodule columns stretching the table
- Refactor template to share more HTML nodes
- Introduce CSS helper classes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 25, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 25, 2020
@lafriks lafriks added this to the 1.13.0 milestone Aug 25, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Aug 26, 2020

🚀

@techknowlogick techknowlogick merged commit 7d14d6c into go-gitea:master Aug 26, 2020
@silverwind silverwind deleted the fix-links branch August 26, 2020 15:55
@silverwind silverwind mentioned this pull request Aug 26, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@CirnoT CirnoT CirnoT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@silverwind @techknowlogick @lafriks @CirnoT @GiteaBot @zeripath