Automatic update of translations #2585

jonasfranz · 2017-09-23T08:24:09Z

This PR adds a build step for master-build. The step uploads locale_en-US.ini to crowdin via the provided API.

@tboerger This PR needs a new drone secret crowdin_key containing the API key of the gitea project. (https://crowdin.com/project/gitea/settings#api)

@tboerger Is the english source file called "locale_en-US.ini" at crowdin?

EDIT

As said on discord, maybe it makes more sense to build a drone plugin for upload and download of translations, this way anybody can prepare a malicious pull request to read the access token because I can only limit the injection to the used image and the events.

I've created a plugin for this PR and updated the .drone.yml to use this plugin. The plugin requires the crowdin key as secret CROWDIN_KEY (CC @tboerger).

Link to plugin repo: https://github.com/JonasFranzDEV/drone-crowdin
Published on Docker hub: https://hub.docker.com/r/jonasfranz/crowdin/

Working example of the plugin:

Drone: https://drone.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/5
Git: https://git.jonasfranz.software/JonasFranzDEV/Crowdin-Demo
Crowdin: https://crowdin.com/project/gitea-demo/activity_stream

Signed-off-by: Jonas Franz <[email protected]>

Adding build step for uploading translations Signed-off-by: Jonas Franz <[email protected]>

Signed-off-by: Jonas Franz <[email protected]>

lunny · 2017-09-23T08:33:05Z

I have added secret for crowdin_key. locale_en-US.ini is the right name.

tboerger · 2017-09-23T08:36:41Z

As said on discord, maybe it makes more sense to build a drone plugin for upload and download of translations, this way anybody can prepare a malicious pull request to read the access token because I can only limit the injection to the used image and the events.

codecov-io · 2017-09-23T08:42:27Z

Codecov Report

Merging #2585 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2585   +/-   ##
=======================================
  Coverage   27.33%   27.33%           
=======================================
  Files          86       86           
  Lines       17137    17137           
=======================================
  Hits         4684     4684           
  Misses      11775    11775           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef8b8b...990d260. Read the comment docs.

Signed-off-by: Jonas Franz <[email protected]>

jonasfranz · 2017-09-23T12:09:44Z

As said on discord, maybe it makes more sense to build a drone plugin for upload and download of translations, this way anybody can prepare a malicious pull request to read the access token because I can only limit the injection to the used image and the events.

I've created a plugin for this PR and updated the .drone.yml to use this plugin. The plugin requires the crowdin key as secret CROWDIN_KEY (CC @tboerger).

Link to plugin repo: https://github.com/JonasFranzDEV/drone-crowdin
Published on Docker hub: https://hub.docker.com/r/jonasfranz/crowdin/

jonasfranz · 2017-09-23T12:11:38Z

Working example of the plugin:

Drone: https://drone.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/5
Git: https://git.jonasfranz.software/JonasFranzDEV/Crowdin-Demo
Crowdin: https://crowdin.com/project/gitea-demo/activity_stream

lafriks · 2017-09-23T12:28:16Z

.drone.yml


+  translations:
+    image: jonasfranz/crowdin
+    secrets: [ CROWDIN_KEY ]


Why secret is uppercase while others in this file are lowercase?

Signed-off-by: Jonas Franz <[email protected]>

lafriks · 2017-09-23T12:44:40Z

LGTM you should probably submit this plugin to drone-plugins :)

jonasfranz · 2017-09-23T14:33:01Z

@lafriks I created a PR for the plugin: drone/drone-plugin-index#71

tboerger · 2017-09-23T15:08:11Z

.drone.yml

      branch: [ master ]

+  translations:
+    image: jonasfranz/crowdin


pull: true below this line

@tboerger Done

daviian · 2017-09-23T15:15:22Z

As I understand the plugin only uploads specified files to crowdin to make them available for translation..
But shouldn't it also download existing translations for release?

jonasfranz · 2017-09-23T15:17:53Z

@daviian Yes it should, but actually it only supports uploading files. I could add downloading in future. But I think that it is enough for this PR.

daviian · 2017-09-23T15:22:17Z

LGTM

daviian · 2017-09-23T15:22:46Z

Make LG-TM work

tboerger · 2017-09-23T17:07:18Z

Maybe I can start to integrate that together with Franz when this plugin gets transferred to the drone-plugins org

lunny · 2017-09-25T04:54:47Z

drone is failed, see https://drone.gitea.io/go-gitea/gitea/910/15

jonasfranz · 2017-09-25T05:53:13Z

We have to add ignore_branch since we are not using branches at crowdin

jonasfranz · 2017-09-25T05:53:24Z

@lunny

lunny · 2017-09-25T05:54:25Z

@JonasFranzDEV OK. So should I change some settings on crowdin or could you send another PR to fix that?

lafriks · 2017-09-25T05:58:02Z

PR to fix that #2599

tboerger · 2017-09-25T07:26:05Z

A note: currently this plugin doesn't commit the changes to the repository, maybe we have to add another step based on https://github.com/appleboy/drone-git-push to get these changes commited with a message including [skip ci] to avoid another CI run?

lafriks · 2017-09-25T07:56:37Z

Downloading changes from crowdin and pushing to git would be best scenario!

jonasfranz · 2017-09-26T08:42:27Z

@tboerger @lafriks I've added a section in the plugin documentation which describes the git push variant: https://github.com/JonasFranzDEV/drone-crowdin/blob/master/DOCS.md#commit-changes

jonasfranz added 7 commits September 13, 2017 18:01

Hotfix for "Add time manually" (go-gitea#2211 (comment))

09f817c

Signed-off-by: Jonas Franz <[email protected]>

Merge branch 'master' of https://github.com/go-gitea/gitea

b3fd467

Merge branch 'master' of https://github.com/go-gitea/gitea

af85943

Merge branch 'master' of https://github.com/go-gitea/gitea

6c9abba

Merge branch 'master' of https://github.com/go-gitea/gitea

752b91d

Adding "upload-translations" task

503e885

Adding build step for uploading translations Signed-off-by: Jonas Franz <[email protected]>

Fixing crowdin project name

7c8af57

Signed-off-by: Jonas Franz <[email protected]>

lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 23, 2017

lunny added this to the 1.3.0 milestone Sep 23, 2017

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2017

Using crowdin plugin

3ba7a47

Signed-off-by: Jonas Franz <[email protected]>

lafriks reviewed Sep 23, 2017

View reviewed changes

Changing secret name

ff59d18

Signed-off-by: Jonas Franz <[email protected]>

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 23, 2017

lafriks approved these changes Sep 23, 2017

View reviewed changes

tboerger reviewed Sep 23, 2017

View reviewed changes

Adding pull: true

728171a

tboerger removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 23, 2017

tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Sep 23, 2017

Merge branch 'master' into translations

990d260

lafriks merged commit fa6d7c7 into go-gitea:master Sep 23, 2017

jonasfranz deleted the translations branch September 23, 2017 16:25

jonasfranz mentioned this pull request Sep 23, 2017

Downloading translations and ignoring branch at Crowdin #2592

Closed

jonasfranz mentioned this pull request Oct 17, 2017

Download and pushing translations #2727

Merged

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Uh oh!

Automatic update of translations #2585

Automatic update of translations #2585

Uh oh!

Conversation

jonasfranz commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lunny commented Sep 23, 2017

Uh oh!

tboerger commented Sep 23, 2017

Uh oh!

codecov-io commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jonasfranz commented Sep 23, 2017

Uh oh!

jonasfranz commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lafriks Sep 23, 2017

Choose a reason for hiding this comment

Uh oh!

lafriks commented Sep 23, 2017

Uh oh!

jonasfranz commented Sep 23, 2017

Uh oh!

tboerger Sep 23, 2017

Choose a reason for hiding this comment

Uh oh!

jonasfranz Sep 23, 2017

Choose a reason for hiding this comment

Uh oh!

daviian commented Sep 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasfranz commented Sep 23, 2017

Uh oh!

daviian commented Sep 23, 2017

Uh oh!

daviian commented Sep 23, 2017

Uh oh!

tboerger commented Sep 23, 2017

Uh oh!

lunny commented Sep 25, 2017

Uh oh!

jonasfranz commented Sep 25, 2017

Uh oh!

jonasfranz commented Sep 25, 2017

Uh oh!

lunny commented Sep 25, 2017

Uh oh!

lafriks commented Sep 25, 2017

Uh oh!

tboerger commented Sep 25, 2017

Uh oh!

lafriks commented Sep 25, 2017

Uh oh!

jonasfranz commented Sep 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jonasfranz commented Sep 23, 2017 •

edited

Loading

codecov-io commented Sep 23, 2017 •

edited

Loading

jonasfranz commented Sep 23, 2017 •

edited

Loading

daviian commented Sep 23, 2017 •

edited

Loading