Avoid showing Failed to change the default wiki branch if repo has no wiki when saving repo settings
#30329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
yp05327
changed the title
Failed to change the default wiki branch when saving repo settingsFailed to change the default wiki branch if repo has no wiki when saving repo settings
lunny
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Apr 8, 2024
wxiaoguang
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/done
wxiaoguang
added
the
skip-changelog
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
Apr 8, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 8, 2024
…no wiki when saving repo settings (go-gitea#30329)
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
Apr 8, 2024
…no wiki when saving repo settings (#30329) (#30337) Backport #30329 by @yp05327 If repo does not have wiki, we should return after save the default wiki branch into DB. Or you will always see `Failed to change the default wiki branch` error. Co-authored-by: yp05327 <[email protected]>
AvengerMoJo
pushed a commit
to AvengerMoJo/gitea
that referenced
this pull request
Apr 8, 2024
…no wiki when saving repo settings (go-gitea#30329)
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 9, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix missed doer (go-gitea#30231) Add optional doctor storage init (go-gitea#30330) Avoid running action when action unit is disabled after workflows detected (go-gitea#30331) Avoid showing `Failed to change the default wiki branch` if repo has no wiki when saving repo settings (go-gitea#30329)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If repo does not have wiki, we should return after save the default wiki branch into DB.
Or you will always see
Failed to change the default wiki brancherror.