Avoid running action when action unit is disabled after workflows detected #30331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Apr 8, 2024
GiteaBot
added
lgtm/done
Contributor
Author
|
maybe we need a test for this, but it is using |
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 8, 2024
…ected (go-gitea#30331) Fix go-gitea#30243 We only checking unit disabled when detecting workflows, but not in runner `FetchTask`. So if a workflow was detected when action unit is enabled, but disabled later, `FetchTask` will still return these detected actions. Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will not effect this.
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Apr 8, 2024
…ected (#30331) (#30338) Backport #30331 by @yp05327 Fix #30243 We only checking unit disabled when detecting workflows, but not in runner `FetchTask`. So if a workflow was detected when action unit is enabled, but disabled later, `FetchTask` will still return these detected actions. Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will not effect this. Co-authored-by: yp05327 <[email protected]>
AvengerMoJo
pushed a commit
to AvengerMoJo/gitea
that referenced
this pull request
Apr 8, 2024
…ected (go-gitea#30331) Fix go-gitea#30243 We only checking unit disabled when detecting workflows, but not in runner `FetchTask`. So if a workflow was detected when action unit is enabled, but disabled later, `FetchTask` will still return these detected actions. Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will not effect this.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 9, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix missed doer (go-gitea#30231) Add optional doctor storage init (go-gitea#30330) Avoid running action when action unit is disabled after workflows detected (go-gitea#30331) Avoid showing `Failed to change the default wiki branch` if repo has no wiki when saving repo settings (go-gitea#30329)
Member
lunny
pushed a commit
that referenced
this pull request
Apr 10, 2024
Fix regression of #30331. ```txt time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous" ```
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 10, 2024
Fix regression of go-gitea#30331. ```txt time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous" ```
lunny
pushed a commit
that referenced
this pull request
Apr 10, 2024
Backport #30382 by @wolfogre Fix regression of #30331. ```txt time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous" ``` I have tested it in my local env, and it should work now. Co-authored-by: Jason Song <[email protected]>
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30243
We only checking unit disabled when detecting workflows, but not in runner
FetchTask.So if a workflow was detected when action unit is enabled, but disabled later,
FetchTaskwill still return these detected actions.Global setting: repo.ENABLED and repository.
DISABLED_REPO_UNITSwill not effect this.