Promise in try/catch

[hinogi]

Consider using 'await' for the promise inside this 'try' or replace it with 'Promise.prototype.catch(...)' usage

https://github.com/hinogi/graphiql/blob/1a3d034c02114c4a164e94626beb840260f05359/packages/graphql-language-service-server/src/MessageProcessor.ts#L994

[dimaMachina]

Your are right!

@acao future mistakes could be avoided by using https://typescript-eslint.io/rules/no-floating-promises/ rule, but since that rule also requires type information CI in followed PR should be fixed first #2878

[hinogi]

you could also add sonarqube to the repo, that's how I found it and it is free for OSS

[hinogi]

Your are right!

@acao future mistakes could be avoided by using https://typescript-eslint.io/rules/no-floating-promises/ rule, but since that rule also requires type information CI in followed PR should be fixed first #2878

I guess there is a js version also
https://github.com/SebastienGllmt/eslint-plugin-no-floating-promise

[dimaMachina]

I guess there is a js version also https://github.com/SebastienGllmt/eslint-plugin-no-floating-promise

The above plugin is not maintained and it always better to use rule that requires type information