[ESLint] enable @typescript-eslint/no-floating-promises, update typescript-eslint to v6
#3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bc2418 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
changed the title
@typescript-eslint/no-floating-promises@typescript-eslint/no-floating-promises, update typescript-eslint to v6
dimaMachina
force-pushed
the
no-floating-promises
branch
from
48cf1a2 to
2bc2418
Compare
TallTed
reviewed
Mar 27, 2023
thomasheyenbrock
approved these changes
Mar 31, 2023
Collaborator
thomasheyenbrock
left a comment
thomasheyenbrock
left a comment
There was a problem hiding this comment.
LGTM, there are a couple of places where we're awaiting now where we did not before, but given the limited context that I have this sounds reasonable 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added changeset explicitly
fixes #2897