url: handle unicode hostname if empty #49396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
|
Suggestion: maintain @Xstoudi as the commit author. |
anonrig
force-pushed
the
url-append-slash
branch
from
159c92c to
4bee90e
Compare
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Aug 29, 2023
anonrig
added
the
author ready
lpinca
approved these changes
Aug 30, 2023
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f863117 |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49396 Fixes: #48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49396 Fixes: nodejs#48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49396 Fixes: #48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49396 Fixes: nodejs/node#48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49396 Fixes: nodejs/node#48759 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR by @Xstoudi seems abandoned (ref: #49087)
Fixes: #48759