[app-server] feat: v2 Thread APIs #6214

owenlin0 · 2025-11-04T19:21:58Z

Implements:

thread/list
thread/start
thread/resume
thread/archive

along with their integration tests. These are relatively light wrappers around the existing core logic, and changes to core logic are minimal.

However, an improvement made for developer ergonomics:

thread/start and thread/resume automatically attaches a conversation listener internally, so clients don't have to make a separate AddConversationListener call like they do today.

For consistency, also updated model/list and feedback/upload (naming conventions, list API params).

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/app-server-protocol/src/protocol/common.rs

Lines 414 to 424 in 943a97c

    
           pub enum ServerNotification { 
        
               /// NEW NOTIFICATIONS 
        
               #[serde(rename = "account/updated")] 
        
               #[ts(rename = "account/updated")] 
        
               #[strum(serialize = "account/updated")] 
        
               AccountUpdated(v2::AccountUpdatedNotification), 
        
               #[serde(rename = "account/rateLimits/updated")] 
        
               #[ts(rename = "account/rateLimits/updated")] 
        
               #[strum(serialize = "account/rateLimits/updated")] 
        
               AccountRateLimitsUpdated(RateLimitSnapshot),

Account rate-limit notification uses old payload shape

The notification enum still declares AccountRateLimitsUpdated(RateLimitSnapshot) yet the commit introduces a new AccountRateLimitsUpdatedNotification type (and tests expect a nested rateLimits object). The send-site continues to pass a raw RateLimitSnapshot, so the emitted JSON lacks the new wrapper and cannot match the updated schema/serialization test. Either the enum variant needs to carry AccountRateLimitsUpdatedNotification or the send logic must wrap the snapshot before serialization; as written the API and implementation are inconsistent and will not build alongside the new test.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codex-rs/app-server/src/codex_message_processor.rs

codex-rs/app-server-protocol/src/protocol/common.rs

codex-rs/app-server-protocol/src/protocol/v2.rs

bolinfest · 2025-11-04T23:23:46Z

codex-rs/app-server-protocol/src/protocol/v2.rs

+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Default, JsonSchema, TS)]
+#[serde(rename_all = "camelCase")]
+#[ts(export_to = "v2/")]


Consider defining a custom attribute macro (in a proc-macro crate) so you can make this one line instead of three.

yeah making sure everything has these annotations is a bit tedious, might do as a followup

codex-rs/app-server-protocol/src/protocol/v2.rs

bolinfest · 2025-11-04T23:32:25Z

codex-rs/app-server-protocol/src/protocol/v2.rs

+#[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)]
+#[serde(rename_all = "camelCase")]
+#[ts(export_to = "v2/")]
+pub struct Thread {


Do we expand this to evolve to contain the history and other metadata?

Yeah will follow up with some additional fields that are useful here. We're pretty inconsistent with the old API.

I'm thinking model_provider, rollout_path, preview might be useful. And created_at and updated_at timestamp would be quite nice I think. https://linear.app/openai/issue/CLI-1377/expose-useful-fields-on-thread

codex-rs/app-server/src/codex_message_processor.rs

bolinfest · 2025-11-05T00:19:03Z

codex-rs/app-server/src/codex_message_processor.rs

+                // Auto-attach a conversation listener when starting a thread.
+                // Use the same behavior as the v1 API with experimental_raw_events=false.
+                if let Err(err) = self
+                    .attach_conversation_listener(new_conv.conversation_id, false)


We auto-add the listener now, but when do we remove it?

i asked codex about the VSCE codebase and it looks like it never calls RemoveConversationListener 😅

however, I think it'd be worth doing on thread/archive at least (will follow up)

codex-rs/app-server/src/codex_message_processor.rs

…resume

bolinfest · 2025-11-05T18:07:23Z

codex-rs/app-server-protocol/src/protocol/v2.rs

-pub struct ListModelsResponse {
-    pub items: Vec<Model>,
+pub struct ModelListResponse {
+    pub data: Vec<Model>,


Should we name this models instead?

I like the convention that the OpenAI APIs have where list APIs have a consistent top-level shape:

{ data: <list of results>, next_cursor: string | null, }

it's nice since no matter which List API you call, the results are always in data

codex-rs/app-server-protocol/src/protocol/v2.rs

bolinfest · 2025-11-05T18:12:25Z

codex-rs/app-server/src/codex_message_processor.rs

-            Some(s) => serde_json::from_str::<RolloutCursor>(&format!("\"{s}\"")).ok(),
-            None => None,
-        };
+        let cursor_obj: Option<RolloutCursor> = cursor.as_ref().and_then(|s| parse_cursor(s));


I'm surprised clippy didn't tell you to do:

Suggested change

let cursor_obj: Option<RolloutCursor> = cursor.as_ref().and_then(|s| parse_cursor(s));

let cursor_obj: Option<RolloutCursor> = cursor.as_ref().and_then(parse_cursor);

interesting, seems like that should work but getting this error:

type mismatch in function arguments expected function signature `fn(&std::string::String) -> _` found function signature `fn(&str) -> _`rustc[Click for full compiler diagnostic](rust-analyzer-diagnostics-view:/diagnostic%20message%20[0]?0#file:///Users/owen/repos/codex/codex-rs/app-server/src/codex_message_processor.rs)

codex-rs/app-server/src/codex_message_processor.rs

owenlin0 changed the title ~~Owen/feature/thread apis~~ [app-server] feat: v2 Thread APIs Nov 4, 2025

owenlin0 force-pushed the owen/feature/thread-apis branch from 77d059e to 48d30c8 Compare November 4, 2025 19:41

owenlin0 marked this pull request as ready for review November 4, 2025 20:10

owenlin0 requested review from apanasenko-oai, bolinfest, celia-oai and pakrym-oai November 4, 2025 20:12

chatgpt-codex-connector bot reviewed Nov 4, 2025

View reviewed changes

codex-rs/app-server/src/codex_message_processor.rs Show resolved Hide resolved

bolinfest reviewed Nov 5, 2025

View reviewed changes

etraut-openai added the oai-pr label Nov 5, 2025

owenlin0 force-pushed the owen/feature/thread-apis branch from 79b6356 to 32716d7 Compare November 5, 2025 01:09

owenlin0 added 7 commits November 4, 2025 20:24

[app-server] feat: v2 Thread APIs

50ef753

add rollout.rs

e3daf81

add back tests

b3be131

comment out thread started notif

62e8697

attach convo listener

5588237

pr feedback

e9a11cb

fix archive common

985ea07

owenlin0 force-pushed the owen/feature/thread-apis branch from 32716d7 to ee62e19 Compare November 5, 2025 05:30

change to u32 and restore comments

3445d53

owenlin0 force-pushed the owen/feature/thread-apis branch from ee62e19 to 3445d53 Compare November 5, 2025 05:31

owenlin0 added 2 commits November 5, 2025 09:27

attach listener before returning response in thread/start and thread/…

dcd6e44

…resume

leverage parse_cursor

7b58568

bolinfest approved these changes Nov 5, 2025

View reviewed changes

more cleanup

9c87436

owenlin0 enabled auto-merge (squash) November 5, 2025 19:45

owenlin0 force-pushed the owen/feature/thread-apis branch from 047b89b to 3f5b1c8 Compare November 5, 2025 20:10

skip flaky test

5e45b6c

owenlin0 force-pushed the owen/feature/thread-apis branch from 3f5b1c8 to 5e45b6c Compare November 5, 2025 20:14

owenlin0 merged commit 2ab1650 into main Nov 5, 2025
25 checks passed

owenlin0 deleted the owen/feature/thread-apis branch November 5, 2025 20:28

github-actions bot locked and limited conversation to collaborators Nov 5, 2025

	pub enum ServerNotification {
	/// NEW NOTIFICATIONS
	#[serde(rename = "account/updated")]
	#[ts(rename = "account/updated")]
	#[strum(serialize = "account/updated")]
	AccountUpdated(v2::AccountUpdatedNotification),

	#[serde(rename = "account/rateLimits/updated")]
	#[ts(rename = "account/rateLimits/updated")]
	#[strum(serialize = "account/rateLimits/updated")]
	AccountRateLimitsUpdated(RateLimitSnapshot),

	let cursor_obj: Option<RolloutCursor> = cursor.as_ref().and_then(\|s\| parse_cursor(s));
	let cursor_obj: Option<RolloutCursor> = cursor.as_ref().and_then(parse_cursor);

[app-server] feat: v2 Thread APIs #6214

[app-server] feat: v2 Thread APIs #6214

Uh oh!

Conversation

owenlin0 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

owenlin0 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

owenlin0 Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

owenlin0 commented Nov 4, 2025 •

edited

Loading

owenlin0 Nov 5, 2025 •

edited

Loading

owenlin0 Nov 5, 2025 •

edited

Loading