[app-server-test-client] feat: auto approve command #6852
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| use codex_app_server_protocol::CommandExecutionRequestAcceptSettings; | ||
| use codex_app_server_protocol::CommandExecutionRequestApprovalParams; | ||
| use codex_app_server_protocol::CommandExecutionRequestApprovalResponse; |
There was a problem hiding this comment.
Imports and the new handler reference CommandExecutionRequest* types and a ServerRequest::CommandExecutionRequestApproval variant, but the codex_app_server_protocol crate only defines ApplyPatchApproval and ExecCommandApproval requests (see app-server-protocol/src/protocol/common.rs:428-433). Because those symbols do not exist in the dependency, this crate will not compile after this commit. Add the corresponding protocol types/variant or remove these references to restore a successful build.
Useful? React with 👍 / 👎.
Extending the
trigger-cmd-approvalsubcommand to automatically approve the command to see the full flow of anexec approval.