Skip to content

Conversation

@owenlin0
Copy link
Contributor

@owenlin0 owenlin0 commented Nov 21, 2025

Add a Declined status for when we request an approval from the user and the user declines. This allows us to distinguish from commands that actually ran, but failed.

This behaves similarly to apply_patch / FileChange, which does the same thing.

@owenlin0 owenlin0 force-pushed the owen/add_declined_status_for_command_exec branch 2 times, most recently from 77505d3 to e0ce5ac Compare November 21, 2025 16:37
@owenlin0 owenlin0 marked this pull request as ready for review November 21, 2025 16:38
@owenlin0
Copy link
Contributor Author

@codex review this

@owenlin0 owenlin0 force-pushed the owen/add_declined_status_for_command_exec branch from e0ce5ac to 1e146bd Compare November 21, 2025 16:46
@owenlin0 owenlin0 force-pushed the owen/add_declined_status_for_command_exec branch from 1e146bd to 7ee80aa Compare November 21, 2025 16:47
@chatgpt-codex-connector
Copy link
Contributor

💡 Codex Review

pub enum CommandExecutionStatus {
InProgress,
Completed,
Failed,
Declined,

P2 Badge Update TS types for declined command status

Command executions can now complete with a Declined status when the user rejects an approval request (see new enum variant added here), but the TypeScript SDK still constrains CommandExecutionStatus to "in_progress" | "completed" | "failed" (sdk/typescript/src/items.ts:6). Any v2 client consuming these notifications through the SDK will now see type errors or unhandled values when a command is declined. The SDK’s union should be extended to include "declined" so clients can safely process the new status.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@owenlin0 owenlin0 merged commit 2ae1f81 into main Nov 21, 2025
25 checks passed
@owenlin0 owenlin0 deleted the owen/add_declined_status_for_command_exec branch November 21, 2025 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants