-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix Nix cargo output hashes for rmcp and filedescriptor #7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
codex-rs/default.nix
Outdated
| cargoLock.outputHashes = { | ||
| "ratatui-0.29.0" = "sha256-HBvT5c8GsiCxMffNjJGLmHnvG77A6cqEL+1ARurBXho="; | ||
| "crossterm-0.28.1" = "sha256-6qCtfSMuXACKFb9ATID39XyFDIEMFDmbx6SSmNe+728="; | ||
| "rmcp-0.9.0" = "sha256-0iPrpf0Ha/facO3p5e0hUKHBqGp/iS+C+OdS+pRKMOU="; | ||
| "filedescriptor-0.8.3" = "sha256-juXYvQWnzJ2SA0CzQU2+D0kOcLu4jLlX29f14vCYtfQ="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add output hash for portable-pty git dependency
The cargoLock.outputHashes list now includes the new git-sourced filedescriptor, but it still omits portable-pty even though Cargo.toml patches that crate to the same git repo/branch (line 292) and Cargo.lock records it as a git source (portable-pty 0.9.0 from pakrym/wezterm). When rustPlatform.buildRustPackage evaluates this Nix file it will continue to fail with a “missing output hash for portable-pty-0.9.0” error, so the Nix build remains broken after this change.
Useful? React with 👍 / 👎.
|
Thanks for the contribution! |
Fixes #7759:
rmcpentry fromcodex-rs/default.nix’scargoLock.outputHashessince the crate now comes from crates.io and no longer needs a git hash.pakrym/wezterm) sobuildRustPackagecan vendor it.