Skip to content

Conversation

@tyleranton
Copy link
Contributor

Fixes #7759:

  • Drop the stale rmcp entry from codex-rs/default.nix’s cargoLock.outputHashes since the crate now comes from crates.io and no longer needs a git hash.
  • Add the missing hash for the filedescriptor-0.8.3 git dependency (from pakrym/wezterm) so buildRustPackage can vendor it.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tyleranton
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 9, 2025
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 22 to 25
cargoLock.outputHashes = {
"ratatui-0.29.0" = "sha256-HBvT5c8GsiCxMffNjJGLmHnvG77A6cqEL+1ARurBXho=";
"crossterm-0.28.1" = "sha256-6qCtfSMuXACKFb9ATID39XyFDIEMFDmbx6SSmNe+728=";
"rmcp-0.9.0" = "sha256-0iPrpf0Ha/facO3p5e0hUKHBqGp/iS+C+OdS+pRKMOU=";
"filedescriptor-0.8.3" = "sha256-juXYvQWnzJ2SA0CzQU2+D0kOcLu4jLlX29f14vCYtfQ=";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add output hash for portable-pty git dependency

The cargoLock.outputHashes list now includes the new git-sourced filedescriptor, but it still omits portable-pty even though Cargo.toml patches that crate to the same git repo/branch (line 292) and Cargo.lock records it as a git source (portable-pty 0.9.0 from pakrym/wezterm). When rustPlatform.buildRustPackage evaluates this Nix file it will continue to fail with a “missing output hash for portable-pty-0.9.0” error, so the Nix build remains broken after this change.

Useful? React with 👍 / 👎.

@etraut-openai etraut-openai merged commit 2237b70 into openai:main Dec 9, 2025
26 checks passed
@etraut-openai
Copy link
Collaborator

Thanks for the contribution!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
@tyleranton tyleranton deleted the nix-cargo-output-hashes branch December 11, 2025 18:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix build fails: stale rmcp hash and missing filedescriptor hash

2 participants