Skip to content

[3.7] bpo-34604: Use %R because of invisible characters or trailing whitespaces. (GH-9165). #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Dec 5, 2018
Merged

[3.7] bpo-34604: Use %R because of invisible characters or trailing whitespaces. (GH-9165). #10947

serhiy-storchaka merged 1 commit into from
Dec 5, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 5, 2018 •
edited by bedevere-bot
Loading

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski [email protected]

https://bugs.python.org/issue34604

@william-gr @serhiy-storchaka
[3.7] bpo-34604: Use %R because of invisible characters or trailing w…
7fa9077 
…hitespaces. (pythonGH-9165).

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2018
Merged
vstinner
vstinner approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit ac8b47c into python:3.7 Dec 5, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-34c7f0c-3.7 branch December 5, 2018 21:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@serhiy-storchaka @miss-islington
bpo-34604: Use %R because of invisible characters or trailing whitesp…
d3d67f8 
…aces. (pythonGH-9165). (pythonGH-10947)

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski <[email protected]>
(cherry picked from commit ac8b47c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10954 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ac8b47c8b4edd59aaee857717d434df52ec49e6c 2.7

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
serhiy-storchaka pushed a commit that referenced this pull request Dec 5, 2018
@miss-islington @william-gr @serhiy-storchaka
bpo-34604: Use %R because of invisible characters or trailing whitesp…
3a9b334 
…aces. (GH-9165). (GH-10947) (GH-10954)

(cherry picked from commit 34c7f0c)
(cherry picked from commit ac8b47c)

Co-authored-by: William Grzybowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni @william-gr