Skip to content

bpo-34604: Use %R because of invisible characters or trailing whitespaces #9165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Dec 5, 2018
Merged

bpo-34604: Use %R because of invisible characters or trailing whitespaces #9165

serhiy-storchaka merged 1 commit into from
Dec 5, 2018

Conversation

@william-gr
Copy link
Contributor

@william-gr william-gr commented Sep 11, 2018 •
edited by bedevere-bot
Loading

vstinner
vstinner approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka: would you mind to review this change, since you proposed the idea?

@serhiy-storchaka serhiy-storchaka merged commit 34c7f0c into python:master Dec 5, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Thanks @william-gr for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Sorry, @william-gr and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 34c7f0c04e2b4e715b2c3df1875af8939fbe7d0b 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Dec 5, 2018

Sorry, @william-gr and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 34c7f0c04e2b4e715b2c3df1875af8939fbe7d0b 3.6

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Dec 5, 2018
@william-gr @serhiy-storchaka
[3.7] bpo-34604: Use %R because of invisible characters or trailing w…
7fa9077 
…hitespaces. (pythonGH-9165).

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski <[email protected]>
@vstinner
Copy link
Member

vstinner commented Dec 5, 2018

Oh sorry, @william-gr, I forgot this PR. Thanks @serhiy-storchaka for merging it ;-)

@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2018

GH-10947 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Dec 5, 2018
@serhiy-storchaka @william-gr
bpo-34604: Use %R because of invisible characters or trailing whitesp…
ac8b47c 
…aces. (GH-9165). (GH-10947)

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2018
@serhiy-storchaka @miss-islington
bpo-34604: Use %R because of invisible characters or trailing whitesp…
d3d67f8 
…aces. (pythonGH-9165). (pythonGH-10947)

(cherry picked from commit 34c7f0c)

Co-authored-by: William Grzybowski <[email protected]>
(cherry picked from commit ac8b47c)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka pushed a commit that referenced this pull request Dec 5, 2018
@miss-islington @william-gr @serhiy-storchaka
bpo-34604: Use %R because of invisible characters or trailing whitesp…
3a9b334 
…aces. (GH-9165). (GH-10947) (GH-10954)

(cherry picked from commit 34c7f0c)
(cherry picked from commit ac8b47c)

Co-authored-by: William Grzybowski <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@william-gr @miss-islington @vstinner @bedevere-bot @encukou @serhiy-storchaka @the-knights-who-say-ni