[3.7] bpo-35257: fix broken BLDSHARED - needs LDFLAGS too (GH-11297) #11298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BLDSHARED` needs to have both `LDFLAGS` and `LDFLAGS_NODIST`, not just `LDFLAGS_NODIST`; `PY_CORE_LDFLAGS` provides both. For example, as it stands now with just `LDFLAGS_NODIST`, macOS universal builds are broken as the necessary `-arch` flags are no longer passed to the standard library extension module link step from `setup.py` resulting in extension modules being single architecture only. https://bugs.python.org/issue35257 (cherry picked from commit 44a3ee0) Co-authored-by: Ned Deily <[email protected]>
ned-deily
approved these changes
Dec 23, 2018
Contributor
Author
|
@ned-deily: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLDSHAREDneeds to have bothLDFLAGSandLDFLAGS_NODIST, not justLDFLAGS_NODIST;PY_CORE_LDFLAGSprovides both. For example, as it stands now with justLDFLAGS_NODIST, macOS universal builds are broken as the necessary-archflags are no longer passed to the standard library extension module link step fromsetup.pyresulting in extension modules being single architecture only.https://bugs.python.org/issue35257
(cherry picked from commit 44a3ee0)
Co-authored-by: Ned Deily [email protected]
https://bugs.python.org/issue35257