Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented Sep 10, 2019

@zooba
Copy link
Member Author

zooba commented Sep 10, 2019

Note that this will fail until #15850 and #15849 are merged.

@zooba zooba closed this Sep 10, 2019
@zooba zooba reopened this Sep 10, 2019
@zware
Copy link
Member

zware commented Sep 10, 2019

I'm a bit concerned about this one; this leaves us open to being broken by any image update. With Azure being required, that means any update that breaks us forces us to manually intervene in any PR opened before the breakage is fixed. We've had a few instances of that otherwise; I didn't like them :)

@zooba
Copy link
Member Author

zooba commented Sep 10, 2019

I guess given I found two other bugs by doing this, I can't really argue with the possibility :)

I'll see if I can figure out the current names of the images and use them explicitly.

@zooba
Copy link
Member Author

zooba commented Sep 10, 2019

@zware Waiting on your approval

Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware merged commit 801f925 into python:master Sep 10, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
…tests optional (pythonGH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

GH-15879 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
…tests optional (pythonGH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot
Copy link

GH-15880 is a backport of this pull request to the 3.7 branch.

@zooba zooba deleted the bpo-38089 branch September 10, 2019 15:56
zooba added a commit to zooba/cpython that referenced this pull request Sep 10, 2019
zooba added a commit that referenced this pull request Sep 10, 2019
…tests optional (GH-15851)

(cherry picked from commit 801f925)

Co-authored-by: Steve Dower <[email protected]>
zooba added a commit that referenced this pull request Sep 10, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants