gh-95605: Fix float(s) error message when s contains only whitespace
#95665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
added
needs backport to 3.10
mdickinson
commented
Aug 4, 2022
mdickinson
commented
Aug 4, 2022
Member
Author
|
@ericvsmith Would you have bandwidth for review, by any chance? I think it's a fairly simple fix. (Indeed, I was sorely tempted to try a more complicated refactoring and cleanup, but I think that's best left for 3.12.) |
ericvsmith
approved these changes
Aug 9, 2022
Member
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
This looks correct to me. Thanks, @mdickinson!
Member
Author
|
Thanks, @ericvsmith! |
Contributor
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-95858 is a backport of this pull request to the 3.11 branch. |
|
GH-95859 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2022
…hitespace (pythonGH-95665) This PR fixes the error message from float(s) in the case where s contains only whitespace. (cherry picked from commit 97e9cfa) Co-authored-by: Mark Dickinson <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 10, 2022
…hitespace (pythonGH-95665) This PR fixes the error message from float(s) in the case where s contains only whitespace. (cherry picked from commit 97e9cfa) Co-authored-by: Mark Dickinson <[email protected]>
mdickinson
added a commit
that referenced
this pull request
Aug 10, 2022
…ace (GH-95665) (GH-95859) This PR fixes the error message from float(s) in the case where s contains only whitespace. (cherry picked from commit 97e9cfa) Co-authored-by: Mark Dickinson <[email protected]>
mdickinson
added a commit
that referenced
this pull request
Aug 11, 2022
…ace (GH-95665) (GH-95858) This PR fixes the error message from float(s) in the case where s contains only whitespace. (cherry picked from commit 97e9cfa) Co-authored-by: Mark Dickinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error message from
float(s)in the case wherescontains only whitespace.Closes #95605.