[3.11] gh-95605: Fix float(s) error message when s contains only whitespace (GH-95665)
#95858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hitespace (pythonGH-95665) This PR fixes the error message from float(s) in the case where s contains only whitespace. (cherry picked from commit 97e9cfa) Co-authored-by: Mark Dickinson <[email protected]>
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Member
|
@pablogsal This one should be harmless. It's also a rather minor bug that's been there since very early Python 3.x days, so it wouldn't hurt much if it had to wait for 3.11.1. |
Contributor
Author
|
@mdickinson: Status check is done, and it's a success ❌ . |
pablogsal
approved these changes
Aug 10, 2022
Member
|
"Tests / macOS (pull_request)" is failing with some unrelated failures in test_ssl (test_get_server_certificate_timeout) and test_tools. I'll update the branch to force a re-run. EDIT: Looks like the test_ssl failure is known: #95241. Not sure about the test_tools failure - that one vanished on the re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error message from float(s) in the case where s contains only whitespace.
(cherry picked from commit 97e9cfa)
Co-authored-by: Mark Dickinson [email protected]