gh-96478: Fix new test when run in refleak mode #96615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./python.exe -m test -R : test.test_typing would fail, apparently because the dictionary used in the @patch decorator was modified.
JelleZijlstra
requested review from
Fidget-Spinner and
gvanrossum
as code owners
Member
Author
|
cc @sobolevn |
zware
approved these changes
Sep 6, 2022
sobolevn
reviewed
Sep 6, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Ok, I see! Thanks!
The difference is that other test calls clear_overloads() in the end.
Contributor
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-97601 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2022
./python.exe -m test -R : test.test_typing would fail, apparently because the dictionary used in the @patch decorator was modified. (cherry picked from commit f0d9136) Co-authored-by: Jelle Zijlstra <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 27, 2022
./python.exe -m test -R : test.test_typing would fail, apparently because the dictionary used in the @patch decorator was modified. (cherry picked from commit f0d9136) Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
@overloaddecorator on compiled functions is not tested #96478