[3.11] gh-96478: Fix new test when run in refleak mode (GH-96615) #97601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./python.exe -m test -R : test.test_typing would fail, apparently because the dictionary used in the @patch decorator was modified. (cherry picked from commit f0d9136) Co-authored-by: Jelle Zijlstra <[email protected]>
miss-islington
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
Member
|
Currently, @pablogsal: It would be good to get this fix into Python 3.11.0 final. |
Member
|
Currently, many Refleaks 3.11 buildbots are failing because of this missing fix:
|
Contributor
Author
|
Status check is done, and it's a success ✅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./python.exe -m test -R : test.test_typing would fail, apparently
because the dictionary used in the @patch decorator was modified.
(cherry picked from commit f0d9136)
Co-authored-by: Jelle Zijlstra [email protected]
@overloaddecorator on compiled functions is not tested #96478