Skip to content

Forward compatibility with upcoming Socket v1.0 and v0.8 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
May 19, 2017
Merged

Forward compatibility with upcoming Socket v1.0 and v0.8 #88

WyriHaximus merged 1 commit into from
May 19, 2017

Conversation

@clue
Copy link
Member

@clue clue commented May 18, 2017

Builds on top of #84

@clue clue added this to the v0.5.0 milestone May 18, 2017
@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor May 18, 2017 13:28
@clue
Copy link
Member Author

clue commented May 19, 2017

For the reference: This PR will likely need a small update and/or rebasing once #90 is in, so I'd prefer to get that one in first 👍

@WyriHaximus
Copy link
Member

WyriHaximus commented May 19, 2017

For the reference: This PR will likely need a small update and/or rebasing once #90 is in, so I'd prefer to get that one in first 👍

There you go 😄

@clue
Copy link
Member Author

clue commented May 19, 2017

There you go :shipit:

@WyriHaximus WyriHaximus merged commit e5dcc27 into reactphp:master May 19, 2017
@clue clue deleted the socket branch May 19, 2017 23:07
@clue clue mentioned this pull request May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

easy pick maintenance new feature

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @WyriHaximus @jsor