Share Timespec between Unix and Hermit #148847

stepancheg · 2025-11-11T23:08:05Z

move unix version of struct Timespec to common, as is, add a few #[cfg(unix)] and absolute imports
use it in hermit instead of own Timespec

Code is nearly identical, and before this PR, changes to time requires additional and nearly identical changes in hermit's version of Timespec.

rustbot · 2025-11-11T23:08:09Z

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

hkBst · 2025-11-14T18:01:53Z

For easier reviewing perhaps you could do the move in a separate commit, and then the changes in a commit thereafter?

stepancheg · 2025-11-19T00:02:58Z

@hkBst I split the PR into two commits. Hope that helps.

hkBst

@hkBst I split the PR into two commits. Hope that helps.

Thanks, that helped enough that I'm willing to say: this looks good to me.

View changes since this review

bors · 2025-12-09T09:34:28Z

☔ The latest upstream changes (presumably #147572) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-12-10T12:59:47Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

stepancheg · 2025-12-10T13:01:24Z

Ping @ChrisDenton.

stepancheg · 2025-12-12T04:15:12Z

r? @alexcrichton

alexcrichton · 2025-12-13T18:17:15Z

Alas I'm not the best person to review changes such as this any more, so I'm going to roll the dice and select someone else

r? libs

Mark-Simulacrum · 2025-12-13T22:00:54Z

@bors r+

bors · 2025-12-13T22:00:57Z

📌 Commit 1be8960 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…crum Share Timespec between Unix and Hermit - move unix version of `struct Timespec` to `common`, as is, add a few `#[cfg(unix)]` and absolute imports - use it in hermit instead of own `Timespec` Code is nearly identical, and before this PR, changes to time requires additional and nearly identical changes in hermit's version of `Timespec`.

Rollup of 7 pull requests Successful merges: - #146794 (std: reorganize pipe implementations) - #148196 (Implement create_dir_all() to operate iteratively instead of recursively) - #148490 (dangling pointer from temp cleanup) - #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets) - #149885 (replace addr_of_mut with &raw mut in maybeuninit docs) - #149949 (Cleanup of attribute parsing errors) - #149969 (don't use no_main and no_core to test IBT) Failed merges: - #148847 (Share Timespec between Unix and Hermit) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-12-14T16:52:36Z

☔ The latest upstream changes (presumably #149979) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot assigned ChrisDenton Nov 11, 2025

rustbot added O-hermit Operating System: Hermit O-unix Operating system: Unix-like labels Nov 11, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 11, 2025