PHP 8.3: json_validate polyfill #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonBazan
commented
Oct 28, 2022
Ayesh
reviewed
Oct 28, 2022
Ayesh
reviewed
Oct 28, 2022
OskarStark
reviewed
Oct 28, 2022
derrabus
requested changes
Oct 31, 2022
IonBazan
requested review from
Ayesh,
OskarStark and
derrabus
and removed request for
Ayesh,
OskarStark and
derrabus
derrabus
approved these changes
Oct 31, 2022
GromNaN
requested changes
Oct 31, 2022
Ayesh
approved these changes
Oct 31, 2022
Contributor
Ayesh
left a comment
Ayesh
left a comment
There was a problem hiding this comment.
Nice, looks good to me.
I'm not sure what's the best way to tackle the tests that fail because of the lack of precision in the float value assertions.
Thank you.
IonBazan
force-pushed
the
feature/json_validate
branch
from
cc89c32 to
7682b78
Compare
derrabus
approved these changes
Nov 1, 2022
GromNaN
approved these changes
Nov 2, 2022
stof
approved these changes
Nov 2, 2022
IonBazan
force-pushed
the
feature/json_validate
branch
2 times, most recently
from
e2bd94b to
dd84daf
Compare
nicolas-grekas
force-pushed
the
feature/json_validate
branch
from
dd84daf to
3dc33c5
Compare
nicolas-grekas
force-pushed
the
feature/json_validate
branch
from
3dc33c5 to
64c9121
Compare
Member
|
Thank you @IonBazan. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 2, 2022
…derrabus) This PR was merged into the 6.3 branch. Discussion ---------- [HttpFoundation][Validator] Leverage `json_validate()` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | Not needed Let's make use of symfony/polyfill#416. Commits ------- d2b6b49 [HttpFoundation][Validator] Leverage json_validate()
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Dec 2, 2022
…derrabus) This PR was merged into the 6.3 branch. Discussion ---------- [HttpFoundation][Validator] Leverage `json_validate()` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | Not needed Let's make use of symfony/polyfill#416. Commits ------- d2b6b49b76 [HttpFoundation][Validator] Leverage json_validate()
symfony-splitter
pushed a commit
to symfony/http-foundation
that referenced
this pull request
Dec 2, 2022
…derrabus) This PR was merged into the 6.3 branch. Discussion ---------- [HttpFoundation][Validator] Leverage `json_validate()` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | Not needed Let's make use of symfony/polyfill#416. Commits ------- d2b6b49b76 [HttpFoundation][Validator] Leverage json_validate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
json_validate()polyfill - see: https://wiki.php.net/rfc/json_validate.Tests examples were taken from the php-src implementation.
Test failures are unrelated.
Float tests are fixed in #417, remaining PHP 8.2 mbstring test can be sorted out separately.