Skip PHP_FLOAT_* checks on PHP 7.3+ #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Nov 2, 2022
Member
|
Thank you @IonBazan. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 3, 2022
This PR was merged into the 1.26-dev branch. Discussion ---------- PHP 8.3: json_validate polyfill This PR adds `json_validate()` polyfill - see: https://wiki.php.net/rfc/json_validate. Tests examples were taken from the php-src implementation. Test failures are unrelated. Float tests are fixed in #417, remaining PHP 8.2 mbstring test can be sorted out separately. Commits ------- 64c9121 Add json_validate polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips comparing
PHP_FLOAT_MINandPHP_FLOAT_MAXconstants on PHP 7.3 and higher as they changed their values. The test will only be run on PHP 7.1 (using provided polyfill) and PHP 7.2 (using native PHP values).These constants depend on
DBL_MINandDBL_MAXwhich might change depending on the platform and/or compiler. I believe the values have changed in PHP 7.3 due to gcc update or some other time-related factor.