BUG: Fix handling rotated pole (lat/lon) parsing #3815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
dcamron
requested changes
May 15, 2025
Member
dcamron
left a comment
dcamron
left a comment
There was a problem hiding this comment.
Looks good after a letter.
I'm taking a note to find and test us supporting geostationary projections with projection_x_angular_coordinate names sometime in the next few weeks.
Instead of just assuming we should fall back to the geostationary perspective_point_height support, check to see if that attribute is even available, otherwise there's no point in trying. This wasn't done in the first place because it wasn't clear there were other projections with valid coordinates that couldn't be converted to meters.
dopplershift
force-pushed
the
fix-rotated-pole
branch
from
bd738d0 to
d152ace
Compare
dcamron
approved these changes
May 15, 2025
dopplershift
added
the
backport
Contributor
|
🏁 Successfully backported as #3841. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Instead of just assuming we should fall back to the geostationary perspective_point_height support, check to see if that attribute is even available, otherwise there's no point in trying.
This wasn't done in the first place because it wasn't clear there were other projections with valid coordinates that couldn't be converted to meters.
Checklist