Add a new HTMLElementEntry & related stuff
#1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #1972 +/- ##
==========================================
- Coverage 79.09% 78.94% -0.16%
==========================================
Files 839 841 +2
Lines 24952 25056 +104
==========================================
+ Hits 19736 19780 +44
- Misses 5216 5276 +60
🚀 New features to boost your workflow:
|
stloyd
force-pushed
the
task/1967-html-element
branch
3 times, most recently
from
4207405 to
2ac6bf8
Compare
stloyd
force-pushed
the
task/1967-html-element
branch
from
2ac6bf8 to
78718d4
Compare
stloyd
commented
Nov 9, 2025
src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/SchemaConverter.php
Show resolved
Hide resolved
stloyd
force-pushed
the
task/1967-html-element
branch
from
78718d4 to
fa246f4
Compare
stloyd
force-pushed
the
task/1967-html-element
branch
2 times, most recently
from
4473f1c to
7913fa5
Compare
Member
|
Before this can be merged please make the assertions in |
stloyd
force-pushed
the
task/1967-html-element
branch
from
b70a697 to
1c172c1
Compare
Member
|
One last missing thing is scalar function that would let to extract values from Element, similar to those:
Without them there is no way to interact with Element unless we cast it to string which is also not perfect. |
norberttech
reviewed
Nov 9, 2025
norberttech
reviewed
Nov 9, 2025
| } | ||
|
|
||
| #[DataProvider('cast_data_provider')] | ||
| public function test_cast(mixed $value, mixed $expected, ?string $exceptionClass = null) : void |
Member
There was a problem hiding this comment.
it would be good to add few examples of castin HTMLElement and HTMLDocument to string in StringTypeTest
norberttech
reviewed
Nov 9, 2025
norberttech
reviewed
Nov 9, 2025
norberttech
reviewed
Nov 9, 2025
norberttech
reviewed
Nov 9, 2025
stloyd
force-pushed
the
task/1967-html-element
branch
from
1c172c1 to
4a4b74c
Compare
stloyd
force-pushed
the
task/1967-html-element
branch
from
1934786 to
d31d8db
Compare
Member
|
Nice!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1967
Note this requires #1960 to be merged first.Change Log
Added
Fixed
Changed
Removed
Deprecated
Security