Skip to content

Replace intsafe functions with chromium safe math in Utf8Utf16Convert.cpp #4290

@german-one

Description

@german-one

Description of the new feature/enhancement

If #4093 lands we should probably replace the intsafe functions used.

Proposed technical implementation details (optional)

I think #4278 should also be in place first. Otherwise we would be forced to suppress C4100 all the time. And certainly we prefer to use the til namespace anyway.

The places where the intsafe functions are used are methods
til::u8state::operator()
til::u16state::operator()
and the first overloads of functions
til::u8u16
til::u16u8

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CodeHealthIssues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.Issue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsPriority-3A description (P3)Product-MetaThe product is the management of the products.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions