Skip to content

ensure u8u16 handles lead & continuation bytes in separate txns #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHowett-MSFT merged 3 commits into from
Mar 4, 2020
Merged

ensure u8u16 handles lead & continuation bytes in separate txns #4798

DHowett-MSFT merged 3 commits into from
Mar 4, 2020

Conversation

@german-one
Copy link
Contributor

@german-one german-one commented Mar 4, 2020 •
edited
Loading

Summary of the Pull Request

  • don't decrement backIter ahead of the string begin
  • ensure partial multibyte characters are still captured correctly if the state class gets them byte by byte

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

passes unit tests

@german-one german-one changed the title ensure til::u8u16 correctly handles receiving lead, and continuation … ensure til::u8u16 correctly handles receiving lead, and continuation bytes in separate operations Mar 4, 2020
@miniksa miniksa added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. labels Mar 4, 2020
@DHowett-MSFT DHowett-MSFT changed the title ensure til::u8u16 correctly handles receiving lead, and continuation bytes in separate operations ensure til::u8u16 handles lead & continuation bytes in separate txns Mar 4, 2020
DHowett-MSFT
DHowett-MSFT approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@DHowett-MSFT DHowett-MSFT changed the title ensure til::u8u16 handles lead & continuation bytes in separate txns ensure u8u16 handles lead & continuation bytes in separate txns Mar 4, 2020
@DHowett-MSFT DHowett-MSFT merged commit e58a648 into microsoft:master Mar 4, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/german_one/u8u16_backiter branch March 4, 2020 19:15
@DHowett-MSFT DHowett-MSFT restored the dev/german_one/u8u16_backiter branch March 4, 2020 19:15
@DHowett-MSFT DHowett-MSFT deleted the dev/german_one/u8u16_backiter branch March 4, 2020 19:15
@DHowett-MSFT DHowett-MSFT restored the dev/german_one/u8u16_backiter branch March 4, 2020 19:15
@DHowett-MSFT DHowett-MSFT deleted the dev/german_one/u8u16_backiter branch March 4, 2020 19:25
@german-one
Copy link
Contributor Author

german-one commented Mar 4, 2020

Thank you for giving me the chance to resolve my own mistakes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

+1 more reviewer

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal.

Projects

None yet

Milestone

No milestone

3 participants

@german-one @DHowett-MSFT @miniksa