feat(DockerEngine): use API from HaRP instead of using Docker directly #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey18106
approved these changes
May 28, 2025
kyteinsky
reviewed
May 29, 2025
oleksandr-nc
force-pushed
the
feat/HaRP-DockerAPI-wrapper
branch
from
aa76919 to
f217851
Compare
Signed-off-by: Oleksander Piskun <[email protected]>
oleksandr-nc
force-pushed
the
feat/HaRP-DockerAPI-wrapper
branch
from
f217851 to
6cfbeb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #531
Part of the AppAPI for this PR: nextcloud/HaRP#39
In case of using HaRP, we should use its new APIs, as new HaRP build will restirct access to most Docker Engine commands.
CI is expected to fail until the HaRP PR is merged.