Skip to content

Conversation

@Rello
Copy link
Collaborator

@Rello Rello commented Sep 3, 2025

Use themed or neutral icons depending on branding

This PR succeeds #8554 for technical reasons. there, the history of discussions can be found

@Rello
Copy link
Collaborator Author

Rello commented Sep 3, 2025

Nextcloud build with themed icons:

Bildschirmfoto 2025-09-03 um 10 30 49 - Bildschirmfoto 2025-09-03 um 10 31 53 - Bildschirmfoto 2025-09-03 um 12 19 12

Bildschirmfoto 2025-09-03 um 10 30 56

Branded client

Bildschirmfoto 2025-09-03 um 16 11 41 Bildschirmfoto 2025-09-03 um 16 11 56

@Rello Rello force-pushed the feature/dynamicIcons branch from 82fe2ff to 26174a3 Compare September 3, 2025 03:32
@Rello
Copy link
Collaborator Author

Rello commented Sep 3, 2025

@kra-mo

I am testing the client with the different icons.
when you look at my examples above: for the black/monochrome, we just have the NC icon in "ok" state.
for colored, we have the NC icon with the green checkmark. I think this is not correct.

Problem I see is, that this ok sync status is used in other places too - and there the ok makes sense.
Bildschirmfoto 2025-09-03 um 12 20 48

What do you suggest?
for consistency I would suggest that we split the tray-sync-status and the in-app-sync-status icons and use 2 separate ones. what do you think?

@Rello Rello changed the title Use themed or neutral icons depending on branding feat: More modern status icons Sep 3, 2025
@Rello Rello marked this pull request as ready for review September 3, 2025 09:12
Copilot AI and others added 19 commits September 3, 2025 16:13
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
Signed-off-by: Rello <[email protected]>
@Rello Rello force-pushed the feature/dynamicIcons branch from a7013e7 to cf94314 Compare September 3, 2025 09:13
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8691.zip

Digest: sha256:6939fc6a76f3180d0475da246eb68ba8bdf5a9d3d4800c57ed10202b9a51ca7f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2025

@mgallien mgallien enabled auto-merge September 3, 2025 13:54
@mgallien mgallien merged commit e3a7990 into master Sep 3, 2025
18 of 19 checks passed
@mgallien mgallien deleted the feature/dynamicIcons branch September 3, 2025 13:54
@jancborchardt jancborchardt moved this to 🎉 Done in 🖍 Design team Sep 4, 2025
@kra-mo
Copy link
Member

kra-mo commented Sep 4, 2025

What do you suggest?
for consistency I would suggest that we split the tray-sync-status and the in-app-sync-status icons and use 2 separate ones. what do you think?

I'm guessing this is now resolved?

In case it isn't, I can provide assets as needed (it would be nice to update the ones without the logo with the same colors, etc.)

I've said before that the badge is kept on the colored icon just so that it doesn't look off-center as it would without it. It's not ideal, but I couldn't figure out a better option :)

@Rello
Copy link
Collaborator Author

Rello commented Sep 4, 2025

I'm guessing this is now resolved?

Hi,
this PR got merged for some technical dependencies. I will open a followup. we need to do some fine tuning like the one discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants