DomainException thrown in case of errors - No responder registered for format xhtml+xml!

[nickvergessen]

Opposed to Controller::getResponderByHTTPHeader() which was used before, this here no longer checks if there is a responder registered and does not fall back to the default type correctly.
E.g. When you create a share for a file that can not have a preview (e.g. PDF without PDF being enabled), instead of having a proper 404, the response now is:

Technische Details

    Entfernte Adresse: ::1
    Anfragekennung: 3RuRvo3TEr52XxYi3pq6
    Typ: DomainException
    Code: 0
    Nachricht: No responder registered for format xhtml+xml!
    Datei: /home/nickv/Nextcloud/33/server/lib/public/AppFramework/Controller.php
    Zeile: 139


Trace

#0 /home/nickv/Nextcloud/33/server/lib/private/AppFramework/Http/Dispatcher.php(227): OCP\AppFramework\Controller->buildResponse(Object(OCP\AppFramework\Http\DataResponse), '...')
#1 /home/nickv/Nextcloud/33/server/lib/private/AppFramework/Http/Dispatcher.php(118): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\Files_Sharing\Controller\PublicPreviewController), '...')
#2 /home/nickv/Nextcloud/33/server/lib/private/AppFramework/App.php(153): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files_Sharing\Controller\PublicPreviewController), '...')
#3 /home/nickv/Nextcloud/33/server/lib/private/Route/Router.php(321): OC\AppFramework\App::main('...', '...', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#4 /home/nickv/Nextcloud/33/server/lib/base.php(1096): OC\Route\Router->match('...')
#5 /home/nickv/Nextcloud/33/server/index.php(25): OC::handleRequest()
#6 {main}

This works properly until Nextcloud 31.

Originally posted by @nickvergessen in #54627

[nickvergessen]

cc @provokateurin as PR author

[provokateurin]

The problem is that in the request there is no access to the controller. So I think it's only fixable by keeping two implementations and adding Accept header support manually.

[xundeenergie]

I've got the same problem when i tried to GET the monitoring url from my nextcloud-aio installation.

{"reqId":"jA1VcpvASYmQiNqLvo9h","level":3,"time":"2025-11-07T08:26:43+00:00","remoteAddr":"192.168.10.97","user":"--","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/serverinfo/api/v1/info","message":"No responder registered for format xhtml+xml!","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:144.0) Gecko/20100101 Firefox/144.0","version":"32.0.1.2","exception":{"Exception":"DomainException","Message":"No responder registered for format xhtml+xml!","Code":0,"Trace":[{"file":"/var/www/html/lib/public/AppFramework/OCSController.php","line":91,"function":"buildResponse","class":"OCP\\AppFramework\\Controller","type":"->","args":[{"__class__":"OCP\\AppFramework\\Http\\DataResponse"},"xhtml+xml"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":216,"function":"buildResponse","class":"OCP\\AppFramework\\OCSController","type":"->","args":[{"__class__":"OCP\\AppFramework\\Http\\DataResponse"},"xhtml+xml"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":118,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\ServerInfo\\Controller\\ApiController"},"info"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":153,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\ServerInfo\\Controller\\ApiController"},"info"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":321,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\ServerInfo\\Controller\\ApiController","info",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"ocs.serverinfo.api.info"}]},{"file":"/var/www/html/ocs/v1.php","line":61,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/ocsapp/apps/serverinfo/api/v1/info"]},{"file":"/var/www/html/ocs/v2.php","line":8,"args":["/var/www/html/ocs/v1.php"],"function":"require_once"}],"File":"/var/www/html/lib/public/AppFramework/Controller.php","Line":139,"message":"No responder registered for format xhtml+xml!","exception":{},"CustomMessage":"No responder registered for format xhtml+xml!"}}

nextcloud version 32.0.1 installed via AIO

[provokateurin]

Oops yes, I forgot about my PR to fix it. I'll make sure that it's merged for the next patch release.