fix(AppFramework): Check for responder existence #55620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2025
Merged
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
fix/appframework/check-reponder-existence
branch
from
22f2df4 to
f720925
Compare
Member
Author
|
/backport to stable32 |
nickvergessen
approved these changes
Nov 12, 2025
susnux
approved these changes
Nov 12, 2025
Altahrim
approved these changes
Nov 12, 2025
Comment on lines
116
to
+117
| * @param string $format | ||
| * @param \Closure $responder | ||
| * @param Closure $responder |
blizzz
reviewed
Nov 18, 2025
| . $format . '!'); | ||
| } | ||
|
|
||
| public function isResponderRegistered(string $responder): bool { |
Member
There was a problem hiding this comment.
@SInCE is missing. Did we not have a check for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55619
Make sure to check that the responder actually exists, before trying to use it instead of falling back to the default.